Add working day tests for countries with substituted holidays by KJhellico · Pull Request #2695 · vacanza/holidays

KJhellico · 2025-07-03T15:56:58Z

Proposed change

Add working day tests for countries with substituted holidays.

Type of change

New country/market holidays support (thank you!)
Supported country/market holidays update (calendar discrepancy fix, localization)
Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
Dependency update (version deprecation/pin/upgrade)
Bugfix (non-breaking change which fixes an issue)
Breaking change (a code change causing existing functionality to break)
New feature (new holidays functionality in general)

Checklist

I've followed the contributing guidelines
I've successfully run make check, all checks and tests are green

coderabbitai · 2025-07-03T15:57:05Z

Summary by CodeRabbit

Bug Fixes
- Updated Hungary's holiday calculations to ensure National Day on March 15 is included for all relevant years.
- Improved Good Friday holiday name checks for Hungary from 2017 onward.
Tests
- Enhanced test coverage for Hungary and Russia to verify substituted holidays and working days.
- Improved inheritance structure for Hungary and Russia test classes to include working day tests.
- Refactored test method positions for Kazakhstan and Vietnam to improve test organization and consistency.
- Renamed and added test methods for clarity and completeness in Russia and Hungary tests.

Walkthrough

The changes introduce or update working day and substituted holiday tests for Hungary, Russia, Kazakhstan, and Vietnam. Hungary’s holiday logic is adjusted to set a start year and alter National Day conditions. Test classes are refactored to inherit from WorkingDayTests, and test methods are reorganized or expanded, especially for substituted holidays and working days.

Changes

Files/Groups	Change Summary
holidays/countries/hungary.py	Added `start_year = 1945` to Hungary class; altered National Day holiday logic for year conditions.
tests/countries/test_hungary.py	Test class now inherits `WorkingDayTests`; added/removed methods for no holidays, substituted holidays, and workdays; updated Good Friday test.
tests/countries/test_russia.py	Test class now inherits `WorkingDayTests`; renamed `test_special_holidays` to `test_substituted_holidays`; added `test_workdays`.
tests/countries/test_kazakhstan.py, tests/countries/test_vietnam.py	Reordered `test_substituted_holidays` and `test_workdays` within their classes; no logic changes.

Suggested labels

test

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate Unit Tests

Create PR with Unit Tests
Post Copyable Unit Tests in a Comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai auto-generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

sonarqubecloud · 2025-07-03T15:58:13Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codecov · 2025-07-03T15:59:22Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (88054e3) to head (047beb6).
Report is 3 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff            @@
##               dev     #2695   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          253       253           
  Lines        15201     15202    +1     
  Branches      2095      2095           
=========================================
+ Hits         15201     15202    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

arkid15r

LGTM

Dismiss for another review

PPsyrius

LGTM 🛠️

Add working day tests for countries with substituted holidays

047beb6

KJhellico requested review from PPsyrius and arkid15r as code owners July 3, 2025 15:56

github-actions Bot added the test label Jul 3, 2025

arkid15r previously approved these changes Jul 3, 2025

View reviewed changes

arkid15r enabled auto-merge July 3, 2025 18:48

PPsyrius approved these changes Jul 4, 2025

View reviewed changes

arkid15r added this pull request to the merge queue Jul 4, 2025

Merged via the queue into vacanza:dev with commit e9d8d74 Jul 4, 2025
33 checks passed

KJhellico deleted the add-working-day-test branch July 4, 2025 09:10

KJhellico mentioned this pull request Jul 7, 2025

v0.76 #2705

Merged

coderabbitai Bot mentioned this pull request Sep 16, 2025

TestCase Syntactic Sugar Support #2881

Merged

24 tasks

coderabbitai Bot mentioned this pull request Mar 23, 2026

Update Russia holidays: add Simplified Chinese language support #3386

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add working day tests for countries with substituted holidays#2695

Add working day tests for countries with substituted holidays#2695
arkid15r merged 1 commit into
vacanza:devfrom
KJhellico:add-working-day-test

KJhellico commented Jul 3, 2025

Uh oh!

coderabbitai Bot commented Jul 3, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

sonarqubecloud Bot commented Jul 3, 2025

Uh oh!

codecov Bot commented Jul 3, 2025 •

edited

Loading

Uh oh!

arkid15r left a comment

Uh oh!

PPsyrius left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

KJhellico commented Jul 3, 2025

Proposed change

Type of change

Checklist

Uh oh!

coderabbitai Bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Suggested labels

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

sonarqubecloud Bot commented Jul 3, 2025

Quality Gate passed

Uh oh!

codecov Bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

arkid15r left a comment

Choose a reason for hiding this comment

Uh oh!

PPsyrius left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai Bot commented Jul 3, 2025 •

edited

Loading

codecov Bot commented Jul 3, 2025 •

edited

Loading