Refactor Cuba holidays: reduce l10n string duplication#2935
Conversation
Summary by CodeRabbit
WalkthroughRefactors Cuba holiday definitions by introducing a shared translated name for the Moncada commemoration and passing it to both Jul 25 and Jul 27 holiday additions, replacing direct translation calls. No public API changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (4)📓 Common learnings📚 Learning: 2025-08-21T04:56:03.780ZApplied to files:
📚 Learning: 2025-06-16T14:08:09.492ZApplied to files:
📚 Learning: 2025-08-21T04:56:03.780ZApplied to files:
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (1)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Ruff (0.12.2)holidays/countries/cuba.py�[1;31mruff failed�[0m Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2935 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 296 296
Lines 17593 17594 +1
Branches 2270 2270
=========================================
+ Hits 17593 17594 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Proposed change
Reduce l10n string duplication in Cuba's holiday code.
This is part of the non-test case changes decoupling from #2881
Type of change
holidaysfunctionality in general)Checklist
make checklocally; all checks and tests passed.