Update Spain holidays in 2008-2009, 2026 #3026

PPsyrius · 2025-10-28T14:30:15Z

Proposed change

Update Spain's holidays for 2008-2009, 2026.
Set Spain's start year as 2008 as we only have references until then.
Add ChristianHolidays::_add_saint_anthonys_day method (used by Italy, Spain, and Portugal).
Add Thai (th) l10n for Spain's holidays.

References:

Ceuta: Sede Electrónica - Ciudad Autónoma de Ceuta
Melilla: Calendario Laboral 2026
Navarre: Resolución 390/2025.
Other Spanish subdivisions: Resolución de 17 de octubre de 2025.

Resolves #3024 .

Type of change

New country/market holidays support (thank you!)
Supported country/market holidays update (calendar discrepancy fix, localization)
Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
Dependency update (version deprecation/pin/upgrade)
Bugfix (non-breaking change which fixes an issue)
Breaking change (a code change causing existing functionality to break)
New feature (new holidays functionality in general)

Checklist

I've read and followed the contributing guidelines.
I've run make check locally; all checks and tests passed.

coderabbitai · 2025-10-28T14:30:31Z

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Reviewing files that changed from the base of the PR and between 57223f3 and e4ed031.

📒 Files selected for processing (18)

README.md (1 hunks)
holidays/countries/italy.py (1 hunks)
holidays/countries/malta.py (1 hunks)
holidays/countries/portugal.py (3 hunks)
holidays/countries/spain.py (12 hunks)
holidays/groups/christian.py (1 hunks)
holidays/locale/ca/LC_MESSAGES/ES.po (3 hunks)
holidays/locale/en_US/LC_MESSAGES/ES.po (3 hunks)
holidays/locale/es/LC_MESSAGES/ES.po (3 hunks)
holidays/locale/th/LC_MESSAGES/ES.po (1 hunks)
holidays/locale/uk/LC_MESSAGES/ES.po (3 hunks)
snapshots/countries/ES_CB.json (12 hunks)
snapshots/countries/ES_CE.json (31 hunks)
snapshots/countries/ES_CT.json (4 hunks)
snapshots/countries/ES_GA.json (3 hunks)
snapshots/countries/ES_MC.json (13 hunks)
snapshots/countries/ES_MD.json (13 hunks)
snapshots/countries/ES_PV.json (10 hunks)

 _____________________________________________________________________________________
< All idioms must be learned. Good idioms only need to be learned once. - Alan Cooper >
 -------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ

Summary by CodeRabbit

New Features
- Added Day of Our Lady of Victory and Melilla Day holidays to the Spanish holiday calendar.
Enhancements
- Extended holiday coverage through 2026 for Spain and its subdivisions.
- Updated Islamic holiday date confirmations (Eid al-Adha and Eid al-Fitr) through 2026.
- Improved holiday observance logic for regional variations.
Tests
- Added test coverage for 2026 holidays across Spanish subdivisions.

Walkthrough

Unified Spain holiday handling: added SUN_TO_NONE import and a start_year = 2008 attribute on Spain, applied uniform observed-date handling, extended Islamic confirmed-year constants to include 2026, updated many regional snapshot mappings to use "Monday following ..." observance (or pruned fixed dates), added 2026-focused tests, and added translations for two new regional holidays.

Changes

Cohort / File(s)	Summary
Core Spain module `holidays/countries/spain.py`	Added `SUN_TO_NONE` to imports; set public `start_year = 2008`; applied SUN_TO_NONE-based observed-date handling across Spain subdivisions; extended `EID_AL_ADHA_DATES_CONFIRMED_YEARS` and `EID_AL_FITR_DATES_CONFIRMED_YEARS` to include 2026; updated comments.
Snapshots — Spain subdivisions `snapshots/countries/ES_*.json` (e.g., `ES_AN.json`,`ES_AR.json`,`ES_AS.json`,`ES_CB.json`,`ES_CE.json`,`ES_CL.json`,`ES_CM.json`,`ES_CN.json`,`ES_COMMON.json`,`ES_CT.json`,`ES_EX.json`,`ES_GA.json`,`ES_IB.json`,`ES_MC.json`,`ES_MD.json`,`ES_ML.json`,`ES_NC.json`,`ES_PV.json`,`ES_RI.json`,`ES_VC.json`)	Large-scale data edits: many fixed-date holiday entries removed or replaced by "Monday following ..." observed variants across many years; additions/extensions of regional 2026 entries (Saint Joseph's Day, Day of Our Lady of Victory, Melilla Day, Eid entries) and widespread pruning/realignment of historic/future fixed-date mappings.
Tests `tests/countries/test_spain.py`	Added `test_fixed_holidays_2026` and `test_variable_holidays_2026` to assert fixed and regional 2026 holiday expectations.
Locales / Translations `holidays/locale/{ca,en_US,es,uk}/LC_MESSAGES/ES.po`	Bumped PO metadata to 0.84 and added translations for "Day of Our Lady of Victory" and "Melilla Day".

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Areas to focus on:
- holidays/countries/spain.py — confirm SUN_TO_NONE is applied consistently and start_year = 2008 interacts correctly with historical logic.
- Snapshot vs. generation logic — ensure snapshot data changes reflect intended observed rules, not accidental deletions.
- Islamic holiday constants — validate extension to 2026 integrates with estimated-date logic and tests.

Possibly related PRs

Add missing subdivisions aliases #2520 — touches the same Spain module and class-level attributes; likely overlaps at file/class level.
Add Canary Islands holidays #2971 — modifies holidays/countries/spain.py and attributes/observed handling; strongly related.
Update Bahrain holidays #2784 — updates confirmed-year ranges for Islamic holidays; related to the Eid constant changes here.

Suggested reviewers

arkid15r
KJhellico

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 3.70% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title "Update Spain holidays in 2008-2009, 2026" references specific years affected by the changes. However, reviewing the raw_summary, the primary technical change is a significant refactoring that replaces numerous year-gated blocks with uniform observed-date handling via SUN_TO_NONE, not primarily about updating specific years' holidays. While the title accurately mentions that 2008-2009 and 2026 are affected (via start_year and extended data), it doesn't capture the core refactoring objective. The title refers to a real aspect of the change but doesn't convey the main point—the shift to uniform observed-date handling and extending support through 2050.
Linked Issues Check	✅ Passed	Issue #3024 requests specific 2026 holidays for various Spanish subdivisions. The changes address these requirements: Saint Joseph's Day entries appear across multiple regions (ES_MC, ES_GA, ES_MD, ES_NC, ES_PV, ES_VC), Islamic holidays (Eid al-Fitr/al-Adha) are extended to 2026, new locale translations for "Day of Our Lady of Victory" (Virgin of Victory/Melilla) and "Melilla Day" support the requested holidays, and Monday-following variants for All Saints' Day and Constitution Day are implemented for affected regions like Andalusia. The extended test cases for 2026 validate the implementations [#3024].
Out of Scope Changes Check	✅ Passed	All observable changes directly serve the objective of updating Spain holidays to 2026. The main code changes (introducing SUN_TO_NONE for observed holidays, setting start_year = 2008, extending Islamic holiday data) support uniform handling of observed dates. Snapshot updates across all subdivisions reflect the holiday extensions. Test additions validate 2026 functionality. Locale file updates provide supporting translations for newly introduced holidays. No changes appear outside the scope of the stated objectives.
Description Check	✅ Passed	The pull request description is directly related to the changeset. The author describes updating Spain's holidays for 2026 and setting the start year to 2008, which aligns with the raw summary showing extensive modifications to holidays/countries/spain.py (including start_year = 2008) and numerous snapshot files reflecting holiday updates through 2026. The description includes specific references to official Spanish government sources and links to the resolved issue #3024, providing concrete context for the changes. While the description mentions adding Thai l10n and a Saint Anthony's Day method that aren't clearly evident in the provided summaries, the core theme of the PR is consistent with the changeset's scope of updating Spanish holiday data.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2025-10-28T14:32:25Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (8a7cbc1) to head (e4ed031).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff            @@
##               dev     #3026   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          306       306           
  Lines        18027     17991   -36     
  Branches      2331      2276   -55     
=========================================
- Hits         18027     17991   -36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…w 2010

coderabbitai

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (3)

snapshots/countries/ES_CE.json (1)
199-210: Add Saint Anthony's Day (June 13, 2026) to Ceuta holidays.

File verification confirms the entry is missing. Ceuta Assembly approved Romería de San Antonio as an official holiday for June 13, 2026. Insert the entry between Eid al-Adha and Santa Maria of Africa.
    "2026-05-27": "Eid al-Adha",
+   "2026-06-13": "Saint Anthony's Day",
    "2026-08-05": "Santa Maria of Africa",
holidays/countries/spain.py (2)
494-518: Add Melilla's missing local holidays for 2026 (Sep 8, Sep 17).

Melilla's official holidays include Virgen de la Victoria (Sep 8) and Día de Melilla (Sep 17), currently absent from the code. Add both with observed-to-next-Monday handling for 2026.
 def _populate_subdiv_ml_public_holidays(self):
@@ -510,6 +510,10 @@ class Spain(HolidayBase):
         else:
             self._add_eid_al_adha_day(name)
 
+        if self._year == 2026:
+            # Virgin of Victory.
+            self._move_holiday(self._add_holiday_sep_8(tr("Virgen de la Victoria")))
+            # Melilla Day.
+            self._move_holiday(self._add_holiday_sep_17(tr("Día de Melilla")))
323-344: Add Ceuta’s Saint Anthony’s Day (Jun 13, 2026) — observed-to-Mon

CE 2026 snapshot and code omit San Antonio; add it to _populate_subdiv_ce_public_holidays using the existing observed-to-Mon pattern.

File: holidays/countries/spain.py — def _populate_subdiv_ce_public_holidays()
 def _populate_subdiv_ce_public_holidays(self):
@@
         else:
             self._add_eid_al_adha_day(name)
+
+        if self._year == 2026:
+            # Saint Anthony's Day.
+            self._move_holiday(self._add_holiday_jun_13(tr("San Antonio")))

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7f1d7cd and 98eaf69.

📒 Files selected for processing (20)

holidays/countries/spain.py (13 hunks)
snapshots/countries/ES_AN.json (20 hunks)
snapshots/countries/ES_AR.json (19 hunks)
snapshots/countries/ES_AS.json (17 hunks)
snapshots/countries/ES_CB.json (7 hunks)
snapshots/countries/ES_CE.json (6 hunks)
snapshots/countries/ES_CL.json (19 hunks)
snapshots/countries/ES_CM.json (7 hunks)
snapshots/countries/ES_CN.json (15 hunks)
snapshots/countries/ES_COMMON.json (1 hunks)
snapshots/countries/ES_CT.json (0 hunks)
snapshots/countries/ES_EX.json (16 hunks)
snapshots/countries/ES_GA.json (2 hunks)
snapshots/countries/ES_IB.json (5 hunks)
snapshots/countries/ES_MC.json (11 hunks)
snapshots/countries/ES_MD.json (11 hunks)
snapshots/countries/ES_ML.json (14 hunks)
snapshots/countries/ES_NC.json (10 hunks)
snapshots/countries/ES_PV.json (2 hunks)
snapshots/countries/ES_RI.json (7 hunks)

💤 Files with no reviewable changes (1)

snapshots/countries/ES_CT.json

🧰 Additional context used

🧠 Learnings (8)

📚 Learning: 2025-04-03T05:59:57.480Z

Learnt from: PPsyrius
PR: vacanza/holidays#2407
File: snapshots/countries/TL_COMMON.json:7-7
Timestamp: 2025-04-03T05:59:57.480Z
Learning: In the holidays project, snapshot files (like snapshots/countries/TL_COMMON.json) are auto-generated when running `make snapshot` and should not be manually edited. Semicolons (;) in holiday entries are used as separators when multiple holidays occur on the same date.

Applied to files:

snapshots/countries/ES_RI.json
snapshots/countries/ES_COMMON.json

📚 Learning: 2025-03-19T16:54:58.657Z

Learnt from: PPsyrius
PR: vacanza/holidays#2354
File: holidays/countries/fiji.py:146-159
Timestamp: 2025-03-19T16:54:58.657Z
Learning: In the holidays library implementation, explicit holiday dates (like Diwali in Fiji) are only defined for historical years with official sources (2016-2025). Future dates beyond the explicitly defined range are automatically calculated by methods like `_add_diwali`, which provide approximations when official dates aren't yet available.

Applied to files:

holidays/countries/spain.py

📚 Learning: 2025-06-18T10:07:58.780Z

Learnt from: PPsyrius
PR: vacanza/holidays#2642
File: holidays/countries/french_southern_territories.py:41-44
Timestamp: 2025-06-18T10:07:58.780Z
Learning: Territorial holiday classes that inherit from parent countries (like HolidaysAX from Finland, HolidaysSJ from Norway, HolidaysTF from France) follow a standard pattern of silently overriding self.subdiv in their _populate_public_holidays() method without validation, as this ensures they always use the correct subdivision code for their territory regardless of user input.

Applied to files:

holidays/countries/spain.py

📚 Learning: 2025-06-18T10:26:50.180Z

Learnt from: PPsyrius
PR: vacanza/holidays#2642
File: holidays/countries/france.py:178-180
Timestamp: 2025-06-18T10:26:50.180Z
Learning: In the France holidays implementation, the _populate_subdiv_57_public_holidays() (Moselle) and _populate_subdiv_6ae_public_holidays() (Alsace) methods are functionally identical, both adding Good Friday (≥1893) and Saint Stephen's Day (≥1892) with the same legal references from August 16th, 1892. Therefore, for the deprecated "Alsace-Moselle" subdivision, calling either method produces the same result.

Applied to files:

holidays/countries/spain.py

📚 Learning: 2025-06-18T10:58:28.058Z

Learnt from: PPsyrius
PR: vacanza/holidays#2642
File: holidays/countries/france.py:184-206
Timestamp: 2025-06-18T10:58:28.058Z
Learning: In the holidays library France implementation, creating shared private methods between subdivision-specific holiday population methods (like _populate_subdiv_57_public_holidays and _populate_subdiv_6ae_public_holidays) is not supported by the current framework architecture, so duplicate code between functionally identical subdivision methods should be left as-is.

Applied to files:

holidays/countries/spain.py

📚 Learning: 2025-03-30T20:18:46.006Z

Learnt from: KJhellico
PR: vacanza/holidays#2386
File: holidays/countries/nepal.py:24-26
Timestamp: 2025-03-30T20:18:46.006Z
Learning: In the holidays library, country classes do not directly implement `_populate()`. Instead, they implement specialized methods like `_populate_public_holidays()`, and the base class `HolidayBase` handles the orchestration by calling these specialized methods.

Applied to files:

holidays/countries/spain.py

📚 Learning: 2025-04-13T19:10:31.502Z

Learnt from: KJhellico
PR: vacanza/holidays#2465
File: holidays/countries/suriname.py:219-251
Timestamp: 2025-04-13T19:10:31.502Z
Learning: The `_CustomIslamicHolidays` classes in this project contain only exact verified holiday dates from reliable sources, rather than calculated or estimated future dates. This is by design to ensure accuracy, particularly for religious holidays that may follow lunar calendars or depend on local observations.

Applied to files:

holidays/countries/spain.py

📚 Learning: 2025-10-03T17:46:23.800Z

Learnt from: KJhellico
PR: vacanza/holidays#2981
File: holidays/calendars/islamic.py:3987-4003
Timestamp: 2025-10-03T17:46:23.800Z
Learning: In the holidays library Islamic calendar implementation with calendar_shift feature, CONFIRMED_YEARS represents years where the base Umm al-Qura calculation plus the calendar_shift has been verified as correct, while confirmed_dates contains explicit dates that should not be shifted. Years within CONFIRMED_YEARS but not in the explicit date dictionaries will use the base Umm al-Qura algorithm with the calendar_shift applied and be marked as "confirmed" rather than "estimated".

Applied to files:

holidays/countries/spain.py

🧬 Code graph analysis (1)

holidays/countries/spain.py (1)

holidays/observed_holiday_base.py (4)

ObservedHolidayBase (102-258)

_add_observed (144-198)

_populate_subdiv_holidays (245-258)

_move_holiday (200-213)

🪛 Ruff (0.14.2)

holidays/countries/spain.py

189-189: Missing return type annotation for private function _populate_subdiv_holidays