Update Burkina Faso holidays: add l10n support by aman-coder03 · Pull Request #3177 · vacanza/holidays

aman-coder03 · 2025-12-29T10:11:04Z

This PR adds missing French (fr) localization for Burkina Faso (BF).

Changes

Introduces BF.po under the French locale
Uses English source strings (msgid) with French translations (msgstr)
Follows existing gettext and locale patterns in the repository

Notes

Translations are based on existing Francophone locale conventions
This is a minimal, incremental addition focused on correctness and consistency

fixes #3175
Part of #3152.

coderabbitai · 2025-12-29T10:11:16Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

Walkthrough

Adds Burkina Faso localization: three BF gettext PO catalogs (fr, en_BF, en_US); marks BurkinaFaso holiday labels and names for translation via gettext alias tr; sets default_language and supported_languages on the BurkinaFaso class; and adds locale tests for fr, en_BF, and en_US.

Changes

Cohort / File(s)	Summary
Localization catalogs `holidays/locale/fr/LC_MESSAGES/BF.po`, `holidays/locale/en_BF/LC_MESSAGES/BF.po`, `holidays/locale/en_US/LC_MESSAGES/BF.po`	Added three BF gettext PO files with headers and message entries for holiday names and pattern strings (`%s (estimated)`, `%s (observed, estimated)`, `%s (observed)`).
Country module `holidays/countries/burkina_faso.py`	Imported `from gettext import gettext as tr`; added `default_language = "en_BF"` and `supported_languages = ("en_BF", "en_US", "fr")`; wrapped label templates and all public holiday name literals with `tr(...)`.
Tests `tests/countries/test_burkina_faso.py`	Added `test_l10n_fr`, `test_l10n_en_bf`, and `test_l10n_en_us` asserting localized holiday names for 2022 (including observed variants).
Docs `README.md`	Updated Burkina Faso languages cell to include `en_BF`, `en_US`, and `fr`.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

Update Nepal holidays: add l10n support #3091 — Similar localization changes: gettext alias/tr usage, added default/supported languages, PO files and tests.
Update Bermuda holidays: add l10n support #2589 — Applies the same localization pattern (gettext wrapping and locale catalogs) across country modules.
Update Bangladesh holidays: add l10n support #3117 — Adds gettext usage and language attributes for another country (similar refactor pattern).

Suggested reviewers

arkid15r
KJhellico
PPsyrius

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: adding localization support for Burkina Faso holidays, which is reflected throughout the changeset.
Description check	✅ Passed	The description is well-related to the changeset, explaining the addition of French localization and referencing the linked issues appropriately.
Linked Issues check	✅ Passed	The PR successfully addresses issue `#3175` by adding French localization (BF.po), implementing gettext patterns, adding tests for multiple locales (fr, en_BF, en_US), and setting en_BF as default while maintaining en_US support.
Out of Scope Changes check	✅ Passed	All changes align with the stated objectives: localization files, translation wrappers, locale configuration, tests, and README updates are all within scope for adding French localization support.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

aman-coder03 · 2026-01-02T08:59:45Z

@KJhellico can you please tell should i go according to the french localisation or english official language?

KJhellico · 2026-01-02T10:59:16Z

should i go according to the french localisation or english official language

These tasks are not conflicting. English should be the official language, and other languages can be added.

aman-coder03 · 2026-01-02T17:02:32Z

thanks for clarifying @KJhellico
i have aligned the implementation accordingly en_US is set as the default language for Burkina Faso, while fr is fully supported as an additional localization.

KJhellico · 2026-01-02T18:39:47Z

en_US is set as the default language for Burkina Faso

en_BF

?

aman-coder03 · 2026-01-03T19:17:12Z

hey yes you are right, the default locale should be en_BF, not en_US.

KJhellico · 2026-01-03T20:31:03Z

en_US locale must also be present in all localized countries. And pay attention to Labor/Labour.

aman-coder03 · 2026-01-05T12:36:58Z

thanks for your guidance @KJhellico
i have added the en_US locale back alongside en_BF, and corrected the Labor/Labour spelling per locale (Labor Day for en_US, Labour Day for en_BF)

KJhellico · 2026-01-09T17:13:03Z

Please, don't change the commit history in published PR without extreme reason.

aman-coder03 · 2026-01-10T09:14:10Z

@KJhellico i am on Windows without make
would you be okay if I leave make l10n to CI, or if a maintainer runs it before merge?

KJhellico · 2026-01-10T17:20:16Z

i am on Windows without make

We have make.cmd script for Windows.

KJhellico

LGTM.

PPsyrius

LGTM 🇧🇫

@aman-coder03 IMO you might want to add your own name to the CONTRIBUTORS file as well

aman-coder03 · 2026-02-24T03:31:26Z

@PPsyrius sure I will do that

…into l10n-fr-bf

sonarqubecloud · 2026-02-24T03:54:41Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

arkid15r

Awesome! Thanks for this l10n contribution @aman-coder03 👍

aman-coder03 · 2026-02-25T04:08:05Z

thanks @arkid15r looking forward to contribute more

aman-coder03 requested review from KJhellico, PPsyrius and arkid15r as code owners December 29, 2025 10:11

github-actions Bot added the l10n label Dec 29, 2025

aman-coder03 mentioned this pull request Dec 29, 2025

Missing l10n for non-English official language countries #3152

Open

KJhellico reviewed Dec 29, 2025

View reviewed changes

Comment thread holidays/locale/fr/LC_MESSAGES/BF.po

KJhellico marked this pull request as draft December 29, 2025 10:26

github-actions Bot added the test label Dec 29, 2025

aman-coder03 force-pushed the l10n-fr-bf branch from 55bbb34 to 69c234f Compare December 30, 2025 07:50

aman-coder03 marked this pull request as ready for review December 31, 2025 15:26

KJhellico marked this pull request as draft December 31, 2025 16:53

aman-coder03 force-pushed the l10n-fr-bf branch from 5200b0b to a487199 Compare January 2, 2026 16:42

github-actions Bot added the snapshot label Jan 9, 2026

aman-coder03 force-pushed the l10n-fr-bf branch from 7cc4a32 to 6b795ad Compare January 9, 2026 08:15

coderabbitai Bot previously approved these changes Jan 9, 2026

View reviewed changes

KJhellico reviewed Jan 9, 2026

View reviewed changes

aman-coder03 dismissed coderabbitai[bot]’s stale review via 4fbef18 January 10, 2026 09:09

coderabbitai Bot previously approved these changes Jan 10, 2026

View reviewed changes

KJhellico reviewed Jan 10, 2026

View reviewed changes

Comment thread holidays/locale/en_US/LC_MESSAGES/BF.po Outdated

aman-coder03 and others added 4 commits February 23, 2026 22:58

pre-commit fix in test+addressing review comments

9b528f1

deleting test_2022

cc9bf5a

Merge branch 'dev' into l10n-fr-bf

d28a9ba

Update code

479bd2a

KJhellico previously approved these changes Feb 23, 2026

View reviewed changes

PPsyrius previously approved these changes Feb 24, 2026

View reviewed changes

aman-coder03 added 2 commits February 24, 2026 09:02

updating contributors.md

032969d

Merge branch 'l10n-fr-bf' of https://github.com/aman-coder03/holidays …

22a2d06

…into l10n-fr-bf

aman-coder03 dismissed stale reviews from PPsyrius and KJhellico via 22a2d06 February 24, 2026 03:36

aman-coder03 requested review from KJhellico and PPsyrius February 24, 2026 03:44

PPsyrius reviewed Feb 24, 2026

View reviewed changes

Comment thread CONTRIBUTORS Outdated

reordering

c562168

PPsyrius approved these changes Feb 24, 2026

View reviewed changes

KJhellico approved these changes Feb 24, 2026

View reviewed changes

arkid15r added this pull request to the merge queue Feb 24, 2026

arkid15r approved these changes Feb 24, 2026

View reviewed changes

Merged via the queue into vacanza:dev with commit 5897eed Feb 24, 2026
32 checks passed

KJhellico mentioned this pull request Mar 2, 2026

v0.92 #3305

Merged

coderabbitai Bot mentioned this pull request Mar 3, 2026

Update Gabon holidays: add l10n support #3178

Merged

coderabbitai Bot mentioned this pull request Apr 3, 2026

Refactor PO generator for robust metadata and improved class discovery #3204

Merged

9 tasks

Uh oh!

Conversation

aman-coder03 commented Dec 29, 2025

Changes

Notes

Uh oh!

coderabbitai Bot commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

❌ Failed checks (1 warning)

Uh oh!

Uh oh!

aman-coder03 commented Jan 2, 2026

Uh oh!

KJhellico commented Jan 2, 2026

Uh oh!

aman-coder03 commented Jan 2, 2026

Uh oh!

KJhellico commented Jan 2, 2026

Uh oh!

aman-coder03 commented Jan 3, 2026

Uh oh!

KJhellico commented Jan 3, 2026

Uh oh!

aman-coder03 commented Jan 5, 2026

Uh oh!

KJhellico commented Jan 9, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aman-coder03 commented Jan 10, 2026

Uh oh!

KJhellico commented Jan 10, 2026

Uh oh!

Uh oh!

KJhellico left a comment

Choose a reason for hiding this comment

Uh oh!

PPsyrius left a comment

Choose a reason for hiding this comment

Uh oh!

aman-coder03 commented Feb 24, 2026

Uh oh!

Uh oh!

sonarqubecloud Bot commented Feb 24, 2026

Quality Gate passed

Uh oh!

arkid15r left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aman-coder03 commented Feb 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai Bot commented Dec 29, 2025 •

edited

Loading