Skip to content

Update China holidays: add additional substituted holidays in 2019 #3294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arkid15r merged 1 commit into from
Feb 24, 2026
Merged

Update China holidays: add additional substituted holidays in 2019 #3294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions holidays/countries/china.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ class China(ObservedHolidayBase, ChineseCalendarHolidays, InternationalHolidays,
* [2021](https://web.archive.org/web/20250424075325/https://www.gov.cn/gongbao/content/2020/content_5567750.htm)
* [2020 Extensions](https://web.archive.org/web/20250427184932/https://www.gov.cn/zhengce/zhengceku/2020-01/27/content_5472352.htm)
* [2020](https://web.archive.org/web/20241222150612/https://www.gov.cn/gongbao/content/2019/content_5459138.htm)
* [2019 Extensions](https://web.archive.org/web/20250901174347/https://www.gov.cn/gongbao/content/2019/content_5380356.htm)
* [2019](https://web.archive.org/web/20241202235023/https://www.gov.cn/gongbao/content/2018/content_5350046.htm)
* [2018](https://web.archive.org/web/20231205013402/https://www.gov.cn/gongbao/content/2017/content_5248221.htm)
* [2017](https://web.archive.org/web/20231205013333/https://www.gov.cn/gongbao/content/2016/content_5148793.htm)
Expand Down Expand Up @@ -394,6 +395,8 @@ class ChinaStaticHolidays:
2019: (
(FEB, 4, FEB, 2), # Spring Festival
(FEB, 8, FEB, 3), # Spring Festival
(MAY, 2, APR, 28), # Labor Day
(MAY, 3, MAY, 5), # Labor Day
(OCT, 4, SEP, 29), # National Day
(OCT, 7, OCT, 12), # National Day
),
Expand Down
2 changes: 2 additions & 0 deletions snapshots/countries/CN_COMMON.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1008,6 +1008,8 @@
"2019-03-08": "International Women's Day",
"2019-04-05": "Tomb-Sweeping Day",
"2019-05-01": "Labor Day",
"2019-05-02": "Day off (substituted from 04/28/2019)",
"2019-05-03": "Day off (substituted from 05/05/2019)",
"2019-05-04": "Youth Day",
"2019-06-01": "Children's Day",
"2019-06-07": "Dragon Boat Festival",
Expand Down
7 changes: 7 additions & 0 deletions tests/countries/test_china.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,8 @@ def test_substituted_holidays(self):
"2018-12-31",
"2019-02-04",
"2019-02-08",
"2019-05-02",
"2019-05-03",
"2019-10-04",
"2019-10-07",
"2020-01-24",
Expand Down Expand Up @@ -317,6 +319,8 @@ def test_workdays(self):
"2018-12-29",
"2019-02-02",
"2019-02-03",
"2019-04-28",
"2019-05-05",
"2019-09-29",
"2019-10-12",
"2020-01-19",
Expand Down Expand Up @@ -1143,6 +1147,7 @@ def test_2018_public_holiday(self):

def test_2019_public_holiday(self):
# https://www.gov.cn/gongbao/content/2018/content_5350046.htm
# https://www.gov.cn/gongbao/content/2019/content_5380356.htm
self.assertHolidaysInYear(
2019,
("2019-01-01", "元旦"),
Expand All @@ -1153,6 +1158,8 @@ def test_2019_public_holiday(self):
("2019-02-08", "休息日（2019-02-03日起取代）"),
("2019-04-05", "清明节"),
("2019-05-01", "劳动节"),
("2019-05-02", "休息日（2019-04-28日起取代）"),
("2019-05-03", "休息日（2019-05-05日起取代）"),
("2019-06-07", "端午节"),
("2019-09-13", "中秋节"),
("2019-10-01", "国庆节"),
Expand Down