Update Marshall Islands holidays: fix General Election Day#3337
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #3337 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 310 310
Lines 18578 18578
Branches 2379 2379
=========================================
Hits 18578 18578 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
Summary by CodeRabbitMarshall Islands Holidays Updated
WalkthroughMarch 1 remembrance-day label changed to "Memorial Day and Nuclear Survivors Remembrance Day" for 2004–2005 only; General Election Day now applies only for years >= 2015 and year % 4 == 3; docstring/public-law references and tests/snapshots updated accordingly. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@holidays/countries/marshall_islands.py`:
- Line 29: Remove the non-authoritative article reference string
("http://archive.today/.../https://www.pomoculture.org/...") from the Marshall
Islands holidays module; edit the marshall_islands.py source to delete that URL
entry from the references/comments so only legal/public-law links that support
rule history remain, and ensure no test fixtures or docstrings depend on that
line (search for the URL or any reference list variable in the module such as
class or module-level references to confirm removal).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 80ce4736-c08f-4a3e-919d-eda20c47e867
📒 Files selected for processing (3)
holidays/countries/marshall_islands.pysnapshots/countries/MH_COMMON.jsontests/countries/test_marshall_islands.py
KJhellico
reviewed
Mar 18, 2026
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> Signed-off-by: Panpakorn Siripanich <19505219+PPsyrius@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/countries/test_marshall_islands.py`:
- Around line 37-46: The long test assertion in
test_nuclear_victims_remembrance_day exceeds the 99-char limit; refactor the
assertNoHolidayName call that checks name_2003 so the long range arguments are
split across multiple lines (e.g., place each range(...) argument on its own
line or assign the ranges to short-named variables before calling
assertNoHolidayName) while keeping the same arguments and using the existing
assertNoHolidayName symbol to preserve behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 354d931f-5a3e-4d3a-be23-dfd298e61650
📒 Files selected for processing (2)
holidays/countries/marshall_islands.pytests/countries/test_marshall_islands.py
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
I've re-strumbled on my own unfinished branch for Marshall Islands from last year and added some post-1998 changes that wasn't part of #3335, which includes:
Type of change
holidaysfunctionality in general)Checklist
make checklocally; all checks and tests passed.