Update Australia holidays: change ANZAC Day holiday in 2026 (ACT) by simongreen-net · Pull Request #3395 · vacanza/holidays

simongreen-net · 2026-03-24T12:32:20Z

Proposed change

The ACT government have changed the ANZAC Day holiday (again!) in 2026 to match NSW for 2026 only.

Type of change

New country/market holidays support (thank you!)
Supported country/market holidays update (calendar discrepancy fix, localization)
Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
Dependency update (version deprecation/pin/upgrade)
Bugfix (non-breaking change which fixes an issue)
Breaking change (a code change causing existing functionality to break)
New feature (new holidays functionality in general)

Checklist

I've read and followed the contributing guidelines.
I've run make check locally; all checks and tests passed.

coderabbitai · 2026-03-24T12:32:35Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

Walkthrough

Updated ACT ANZAC Day logic: keep the base ANZAC Day on 2026-04-25 and add a separate observed holiday on 2026-04-27; adjusted inline ACT reference link. Tests updated to assert both original and observed dates and to adjust 2027 assertions accordingly.

Changes

Cohort / File(s)	Summary
ANZAC Day Observation Logic `holidays/countries/australia.py`	Changed ACT handling for ANZAC Day (2026): stop moving the base 25‑Apr holiday, add a separate observed holiday via `_add_observed(...)`, and update the ACT reference link.
Test Assertions `tests/countries/test_australia.py`	Updated ACT-specific assertions in `test_anzac_day`: assert `ANZAC Day` on `2026-04-25`, assert `ANZAC Day (observed)` on `2026-04-27`, and adjust 2027 presence/absence checks for original and observed labels.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Update Australia holidays: add extra ANZAC Day holiday in NSW #3273: Modifies ACT ANZAC Day observed creation for 2026–2027 in the same code area.
Refactor Australia holidays #2828: Switches Australia ANZAC Day handling from moving the base holiday to adding an observed date.
Update Australia holidays: move Anzac Day in 2026 (ACT) #3216: Also alters ACT ANZAC Day 2026 behavior around move vs add-observed logic.

Suggested reviewers

arkid15r
PPsyrius

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description explains the ACT government's change to ANZAC Day in 2026 and properly categorizes it as a supported holidays update.
Title check	✅ Passed	The title accurately describes the main change: updating ANZAC Day holiday handling in ACT for 2026, which is the core focus of the changeset across both implementation and test files.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

simongreen-net · 2026-03-24T12:34:52Z

News article that mentions the change: https://www.9news.com.au/national/anzac-day-public-holiday-act-2026-announced-to-align-with-nsw/5ab9b03e-b3c1-4b40-a940-bb3c3d3e8d00

ACT government website with the change: https://www.act.gov.au/living-in-the-act/public-holidays-school-terms-and-daylight-saving

However, when I try and save the page in the WBM bot checks get in the way: https://web.archive.org/web/20260324122019/https://www.act.gov.au/web/20260324122019/https://www.act.gov.au/living-in-the-act/public-holidays-school-terms-and-daylight-saving

Open to idea on how to work around this.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@tests/countries/test_australia.py`:
- Around line 151-156: Add a one-off boundary assertion for 2027 to ensure the
ACT observed behavior is limited to 2026: after the existing 2026 assertions
that use assertHolidayName, add assertions that the regular holiday still
appears for "2027-04-25" (using assertHolidayName with the same name) and that
the observed variant (name + " (observed)") does not appear on "2027-04-27" (use
the test helper that asserts absence, e.g., assertNoHoliday or equivalent) so
accidental broadening beyond 2026 is caught.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 3adb5dc8-1499-47b9-8eb7-2ab1fe887fb4

📥 Commits

Reviewing files that changed from the base of the PR and between bd01922 and 13c964b.

📒 Files selected for processing (2)

holidays/countries/australia.py
tests/countries/test_australia.py

PPsyrius · 2026-03-24T13:26:43Z

However, when I try and save the page in the WBM bot checks get in the way: https://web.archive.org/web/20260324122019/https://www.act.gov.au/web/20260324122019/https://www.act.gov.au/living-in-the-act/public-holidays-school-terms-and-daylight-saving

Open to idea on how to work around this.

The secondary site we use for this is usually archive.todaywhich works in this case
http://archive.today/2026.03.24-132232/https://www.act.gov.au/living-in-the-act/public-holidays-school-terms-and-daylight-saving

If that fails but PDF version exists i.e. the Philippines government website, we normally download those then upload them as documents to the Internet Archive directly

In worst case scenario though, you can put the raw, unarchived link as-is for now and we can figure out how to deal with that later

codecov · 2026-03-24T14:20:18Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (8e468e0) to head (28bf0e8).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff            @@
##               dev     #3395   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          312       312           
  Lines        18644     18644           
  Branches      2383      2383           
=========================================
  Hits         18644     18644

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> Signed-off-by: Panpakorn Siripanich <19505219+PPsyrius@users.noreply.github.com>

PPsyrius · 2026-03-29T16:37:02Z

I'm applying code review suggestions directly for now so that we can get this PR merged in time for the first release for April 🙏

Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> Signed-off-by: Panpakorn Siripanich <19505219+PPsyrius@users.noreply.github.com>

KJhellico

LGTM.

sonarqubecloud · 2026-03-31T02:44:31Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

arkid15r

Thanks for updating that @simongreen-net 👍

Add changes for ANZAC Day holiday in 2026

13c964b

github-actions Bot added the test label Mar 24, 2026

coderabbitai Bot reviewed Mar 24, 2026

View reviewed changes

Comment thread tests/countries/test_australia.py Outdated

simongreen-net requested review from KJhellico, PPsyrius and arkid15r as code owners March 24, 2026 12:57

Add ACT ANZAC Day test in 2027

bbcf5b6

simongreen-net force-pushed the act-anzac-day-2026 branch from dfba0f3 to bbcf5b6 Compare March 24, 2026 13:12

KJhellico reviewed Mar 24, 2026

View reviewed changes

Comment thread tests/countries/test_australia.py Outdated

Update link for ACT 2026-29

dbe6132

simongreen-net force-pushed the act-anzac-day-2026 branch from c22ec6a to dbe6132 Compare March 25, 2026 07:57

PPsyrius and others added 2 commits March 29, 2026 23:35

Simplify test cases

5f7e592

Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> Signed-off-by: Panpakorn Siripanich <19505219+PPsyrius@users.noreply.github.com>

Merge branch 'dev' into act-anzac-day-2026

23ee3d5

PPsyrius requested a review from KJhellico March 29, 2026 16:35

KJhellico reviewed Mar 29, 2026

View reviewed changes

Comment thread tests/countries/test_australia.py Outdated

Fix test cases

f03aa06

Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> Signed-off-by: Panpakorn Siripanich <19505219+PPsyrius@users.noreply.github.com>

PPsyrius requested a review from KJhellico March 29, 2026 17:02

KJhellico approved these changes Mar 29, 2026

View reviewed changes

KJhellico changed the title ~~Add changes for ANZAC Day holiday in 2026 in ACT~~ Update Australia holidays: change ANZAC Day holiday in 2026 (ACT) Mar 29, 2026

Merge branch 'dev' into act-anzac-day-2026

28bf0e8

arkid15r reviewed Mar 31, 2026

View reviewed changes

arkid15r added this pull request to the merge queue Mar 31, 2026

Merged via the queue into vacanza:dev with commit d8cac3a Mar 31, 2026
32 checks passed

KJhellico mentioned this pull request Apr 6, 2026

v0.94 #3508

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update Australia holidays: change ANZAC Day holiday in 2026 (ACT)#3395

Update Australia holidays: change ANZAC Day holiday in 2026 (ACT)#3395
arkid15r merged 7 commits into
vacanza:devfrom
simongreen-net:act-anzac-day-2026

simongreen-net commented Mar 24, 2026

Uh oh!

coderabbitai Bot commented Mar 24, 2026 •

edited

Loading

Reviews paused

❌ Failed checks (1 warning)

Uh oh!

simongreen-net commented Mar 24, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

PPsyrius commented Mar 24, 2026

Uh oh!

codecov Bot commented Mar 24, 2026 •

edited

Loading

Uh oh!

Uh oh!

PPsyrius commented Mar 29, 2026

Uh oh!

Uh oh!

KJhellico left a comment

Uh oh!

sonarqubecloud Bot commented Mar 31, 2026

Uh oh!

arkid15r left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

simongreen-net commented Mar 24, 2026

Proposed change

Type of change

Checklist

Uh oh!

coderabbitai Bot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

❌ Failed checks (1 warning)

Uh oh!

simongreen-net commented Mar 24, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

PPsyrius commented Mar 24, 2026

Uh oh!

codecov Bot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

PPsyrius commented Mar 29, 2026

Uh oh!

Uh oh!

KJhellico left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Mar 31, 2026

Quality Gate passed

Uh oh!

arkid15r left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai Bot commented Mar 24, 2026 •

edited

Loading

codecov Bot commented Mar 24, 2026 •

edited

Loading