Update India holidays: improve Tamil translations#3437
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughUpdated Tamil translations for several India holiday names in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@holidays/locale/ta/LC_MESSAGES/IN.po`:
- Line 129: The msgstr for the holiday entry currently set to "ரக்ஷா பந்தன்
(அண்ணன்-தங்கை உறவு திருநாள்)" (and the two other entries flagged in the review)
includes extra explanatory text; update each affected msgstr to be a faithful
translation of the msgid (i.e., remove the parenthetical/explanatory portion) so
the value is just the holiday name in Tamil, matching the source msgid exactly
in scope.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 95728a1b-bf4d-4169-8f5e-cfc5ef2ed5fa
📒 Files selected for processing (1)
holidays/locale/ta/LC_MESSAGES/IN.po
There was a problem hiding this comment.
Pull request overview
Refines Tamil (ta) localized holiday names for India (IN.po) to improve linguistic accuracy and consistency for Tamil Nadu context.
Changes:
- Updated several holiday
msgstrvalues (e.g., Independence Day, Janmashtami, Chhath Puja, Odisha Day). - Adjusted transliterations/terminology for select festivals and state observances.
- Added additional descriptive phrasing to a couple of holiday names.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@2024yuva, please pay attention to the bot's comments; they seem reasonable. |
There was a problem hiding this comment.
♻️ Duplicate comments (1)
holidays/locale/ta/LC_MESSAGES/IN.po (1)
185-185:⚠️ Potential issue | 🟡 MinorKeep
Uttarayanas the holiday name only.Line 185 adds
நாள், which broadens the source scope (msgid "Uttarayan"). Please normalize to the holiday-name translation only.Suggested fix
-msgstr "உத்தராயண் நாள்" +msgstr "உத்தராயண்"Based on learnings: when translating holiday names in
.pofiles,msgstrshould be a faithful translation of the originalmsgid, not expanded with extra wording.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@holidays/locale/ta/LC_MESSAGES/IN.po` at line 185, The translation for msgid "Uttarayan" currently expands the name by adding "நாள்"; update the msgstr for msgid "Uttarayan" to only contain the holiday name "Uttarayan" (remove the extra word "நாள்") so the msgstr is a faithful, one-to-one translation of the msgid.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@holidays/locale/ta/LC_MESSAGES/IN.po`:
- Line 185: The translation for msgid "Uttarayan" currently expands the name by
adding "நாள்"; update the msgstr for msgid "Uttarayan" to only contain the
holiday name "Uttarayan" (remove the extra word "நாள்") so the msgstr is a
faithful, one-to-one translation of the msgid.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 1c1a16ea-b453-4149-874a-22bdc846cb9c
📒 Files selected for processing (1)
holidays/locale/ta/LC_MESSAGES/IN.po
Signed-off-by: ~Jhellico <KJhellico@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #3437 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 313 313
Lines 18672 18672
Branches 2385 2385
=========================================
Hits 18672 18672 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This PR focuses on refining existing translations to improve linguistic accuracy, consistency, and cultural relevance, especially for Tamil Nadu context. Several entries were updated to use more commonly accepted Tamil terminology and standardized naming conventions.
Key improvements:
Examples: