Skip to content

Update languages list in site assets generator#3540

Merged
arkid15r merged 1 commit into
vacanza:devfrom
KJhellico:upd-assets-generator
Apr 16, 2026
Merged

Update languages list in site assets generator#3540
arkid15r merged 1 commit into
vacanza:devfrom
KJhellico:upd-assets-generator

Conversation

@KJhellico

@KJhellico KJhellico commented Apr 15, 2026

Copy link
Copy Markdown
Collaborator

Proposed change

Update languages list in site assets generator.
We need to find a way to automate this task. Maybe we need to introduce some kind of "language registry" and keep it up to date (with tests).

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@coderabbitai

coderabbitai Bot commented Apr 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 55893e7d-0164-4d79-b81d-143205ae16f8

📥 Commits

Reviewing files that changed from the base of the PR and between e177d52 and df2c0e2.

📒 Files selected for processing (1)
  • scripts/generate_site_assets.py

Summary by CodeRabbit

  • New Features
    • Added support for 9 new languages and locales: Dzongkha, Kannada, Kirghiz, Malayalam, Marathi, Panjabi, Telugu, English (Burkina Faso), and Russian (Kyrgyzstan).

Walkthrough

Extended the LANGUAGES mapping in the site assets generation script with nine new locale entries for Dzongkha, Kannada, Kirghiz, Malayalam, Marathi, Panjabi, Telugu, and regional variants of English and Russian. This enables proper language name resolution for these locales when processing supported languages.

Changes

Cohort / File(s) Summary
Language Mapping Expansion
scripts/generate_site_assets.py		 Added 9 new locale-to-language mappings (dz, kn, ky, ml, mr, pa, te, en_BF, ru_KG) to the LANGUAGES dictionary for improved locale name resolution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

script

Suggested reviewers

  • arkid15r
  • PPsyrius
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly reflects the main change: adding new language entries to the LANGUAGES mapping in the site assets generator script.
Description check ✅ Passed The description is related to the changeset, explaining the update to the languages list and noting the need for automation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

sonarqubecloud Bot commented Apr 15, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov

codecov Bot commented Apr 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e177d52) to head (df2c0e2).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #3540   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          313       313           
  Lines        18693     18693           
  Branches      2389      2389           
=========================================
  Hits         18693     18693

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

PPsyrius
PPsyrius approved these changes Apr 16, 2026
View reviewed changes

@PPsyrius PPsyrius left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🗒️

arkid15r
arkid15r reviewed Apr 16, 2026
View reviewed changes

@arkid15r arkid15r left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@arkid15r arkid15r added this pull request to the merge queue Apr 16, 2026
Merged via the queue into vacanza:dev with commit 127b839 Apr 16, 2026
32 checks passed
@KJhellico KJhellico deleted the upd-assets-generator branch April 16, 2026 22:09
@coderabbitai coderabbitai Bot mentioned this pull request Apr 18, 2026
Merged
9 tasks
@KJhellico KJhellico mentioned this pull request Apr 20, 2026
Merged
This was referenced Jun 5, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r left review comments

@PPsyrius PPsyrius PPsyrius approved these changes

Assignees

No one assigned

Labels

script

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KJhellico @arkid15r @PPsyrius