Add 2025-2026 Islamic holidays exact dates for Indonesia and Philippines by akshiDhi · Pull Request #3591 · vacanza/holidays

akshiDhi · 2026-05-30T07:59:24Z

Proposed change

Extends confirmed Islamic holiday year ranges to 2026 for Indonesia and Philippines, and adds 2026 Eid al-Fitr exact date for Indonesia.

Changes:

Indonesia: EID_AL_FITR 2026 (MAR 21)
Indonesia: EID_AL_ADHA, HIJRI_NEW_YEAR, MAWLID, ISRA_AND_MIRAJ, LUNAR_NEW_YEAR confirmed years extended to 2026
Philippines: EID_AL_FITR and EID_AL_ADHA confirmed years extended to 2026
Philippines: added Proclamation references for 2026 Eid holidays

Related to #2334

Type of change

New country/market holidays support (thank you!)
Supported country/market holidays update (calendar discrepancy fix, localization)
Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
Dependency update (version deprecation/pin/upgrade)
Bugfix (non-breaking change which fixes an issue)
Breaking change (a code change causing existing functionality to break)
New feature (new holidays functionality in general)

Checklist

I've read and followed the contributing guidelines.
I've run make check locally; all checks and tests passed.

Indonesia: add 2026 Eid al-Fitr confirmed date (MAR 21) Signed-off-by: akshiDhi <jamkim2224@gmail.com>

Philippines: add 2026 Eid al-Fitr confirmed date (MAR 20) Signed-off-by: akshiDhi <jamkim2224@gmail.com>

Indonesia: add 2025-2026 Eid al-Adha confirmed dates Signed-off-by: akshiDhi <jamkim2224@gmail.com>

Philippines: add 2025-2026 Eid al-Adha confirmed dates Signed-off-by: akshiDhi <jamkim2224@gmail.com>

coderabbitai · 2026-05-30T07:59:38Z

Walkthrough

Extend confirmed-year ranges to include 2026 for Indonesia and the Philippines; add 2026 Vesak and 2026 Eid al‑Fitr entries for Indonesia; update Philippines docstring references; add Akshita Dhiman to CONTRIBUTORS.

Changes

Holiday confirmed-year and date updates

Layer / File(s)	Summary
Philippines: docstring and confirmed-year ranges `holidays/countries/philippines.py`	Add two 2026 proclamation links to the docstring; extend `LUNAR_NEW_YEAR_DATES_CONFIRMED_YEARS`, `EID_AL_ADHA_DATES_CONFIRMED_YEARS`, and `EID_AL_FITR_DATES_CONFIRMED_YEARS` to include 2026.
Indonesia: confirmed-year ranges and 2026 dates `holidays/countries/indonesia.py`	Update country docstring reference; add `IndonesiaBuddhistHolidays.VESAK_DATES[2026] = (MAY, 31)`; extend confirmed-year ranges for Lunar New Year and multiple Islamic holidays to 2026; add `IndonesiaIslamicHolidays.EID_AL_FITR_DATES[2026] = (MAR, 21)`.

Repository metadata

Layer / File(s)	Summary
Add CONTRIBUTORS entry `CONTRIBUTORS`	Insert `Akshita Dhiman` into the CONTRIBUTORS list.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

vacanza/holidays#2367: Related adjustments to Philippines Eid’l Fitr/Eid al‑Adha date tables.
vacanza/holidays#2332: Related changes to Philippines and regional Islamic/Chinese holiday date constants.

Suggested labels

snapshot, test

Suggested reviewers

arkid15r
PPsyrius

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title mentions adding 2025-2026 Islamic holidays, but the PR only adds 2026 data and extends confirmed year ranges; 2025 additions are not present in the changeset.	Clarify whether 2025 changes were intended; if only 2026 data was added, update title to reflect this accurately.
Linked Issues check	❓ Inconclusive	The PR extends confirmed year ranges to 2026 for both countries, partially addressing issue `#2334`, but does not implement the full `_IslamicMabimsLunar` calendar system required by the issue.	Verify whether this is an interim update toward the `_IslamicMabimsLunar` implementation or a standalone fix; clarify the relationship to issue `#2334`'s broader objectives.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Out of Scope Changes check	✅ Passed	All changes are in-scope: Indonesia and Philippines holiday data extensions plus a contributor entry addition align with the stated PR objectives.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check	✅ Passed	The pull request description clearly outlines the changes: extending confirmed Islamic holiday ranges to 2026 for Indonesia and Philippines, and adding a 2026 Eid al-Fitr date for Indonesia. It directly relates to the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cubic-dev-ai

No issues found across 2 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

PPsyrius

Please include the references for your data as well in the doctring reference section i.e. https://www.officialgazette.gov.ph/nationwide-holidays/ for the Philippines

Aside from that, feel free to include your own name in the CONTRIBUTORS file as well

Signed-off-by: akshiDhi <jamkim2224@gmail.com>

akshiDhi · 2026-05-30T10:34:50Z

I have addressed all the requested changes. thanks !

codecov · 2026-05-30T10:58:48Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (daadab1) to head (962c762).
⚠️ Report is 3 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff            @@
##               dev     #3591   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          314       314           
  Lines        18820     18820           
  Branches      2408      2408           
=========================================
  Hits         18820     18820

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

PPsyrius

For Indonesia, I ended up rechecking their holidays against https://id.wikipedia.org/wiki/Indonesia_dalam_tahun_2026 (this one is already included in our reference list) - you can safely update these entries' end year from 2025 to 2026 as well without adding year-specific data:

HIJRI_NEW_YEAR_DATES_CONFIRMED_YEARS
MAWLID_DATES_CONFIRMED_YEARS
ISRA_AND_MIRAJ_DATES_CONFIRMED_YEARS
VESAK_DATES
LUNAR_NEW_YEAR_DATES_CONFIRMED_YEARS

Aside from this and the suggested changes below, the rest are LGTM 👍

Signed-off-by: akshiDhi <jamkim2224@gmail.com>

Removed holiday dates for 2025 and 2026 from the Philippines. Signed-off-by: akshiDhi <jamkim2224@gmail.com>

Signed-off-by: akshiDhi <jamkim2224@gmail.com>

coderabbitai

♻️ Duplicate comments (1)

holidays/countries/philippines.py (1)
16-16: ⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

Add MAR back to the Gregorian import list.

Line 16 drops MAR, but Line 240 still uses it in EID_AL_FITR_DATES; this will raise NameError when the module is loaded.
Suggested fix
-from holidays.calendars.gregorian import JAN, FEB, APR, MAY, JUN, JUL, AUG, SEP, OCT, NOV, DEC
+from holidays.calendars.gregorian import JAN, FEB, MAR, APR, MAY, JUN, JUL, AUG, SEP, OCT, NOV, DEC
Also applies to: 240-240
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@holidays/countries/philippines.py` at line 16, The import statement at the
top removed MAR but EID_AL_FITR_DATES still uses MAR, causing a NameError;
restore MAR in the gregorian import list by adding MAR back to the import tuple
(the line that imports JAN, FEB, APR, ... DEC) so that the module-level constant
EID_AL_FITR_DATES can reference MAR successfully.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Duplicate comments:
In `@holidays/countries/philippines.py`:
- Line 16: The import statement at the top removed MAR but EID_AL_FITR_DATES
still uses MAR, causing a NameError; restore MAR in the gregorian import list by
adding MAR back to the import tuple (the line that imports JAN, FEB, APR, ...
DEC) so that the module-level constant EID_AL_FITR_DATES can reference MAR
successfully.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: b23dda7a-d5a8-4eec-8c8c-420784b1c614

📥 Commits

Reviewing files that changed from the base of the PR and between e8af34e and cdc2bdc.

📒 Files selected for processing (2)

holidays/countries/indonesia.py
holidays/countries/philippines.py

💤 Files with no reviewable changes (1)

holidays/countries/indonesia.py

cubic-dev-ai

1 issue found across 2 files (changes from recent commits).

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

Signed-off-by: akshiDhi <jamkim2224@gmail.com>

akshiDhi · 2026-05-30T13:17:54Z

i have addressed the feedbacks, thank you !

Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> Signed-off-by: akshiDhi <jamkim2224@gmail.com>

KJhellico

LGTM.

PPsyrius

Last two

Signed-off-by: akshiDhi <jamkim2224@gmail.com>

cubic-dev-ai · 2026-05-30T14:53:13Z

You're iterating quickly on this pull request. To help protect your rate limits, cubic has paused automatic reviews on new pushes for now—when you're ready for another review, comment @cubic-dev-ai review.

sonarqubecloud · 2026-05-30T14:54:52Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

KJhellico · 2026-05-30T15:47:57Z

@akshiDhi, this PR cannot close #2334, it's a more general issue.

PPsyrius

LGTM 🇮🇩🇵🇭

arkid15r

@akshiDhi thanks for improving those 👍

akshiDhi added 4 commits May 30, 2026 13:13

Update EID_AL_FITR confirmed year to 2026

651c918

Indonesia: add 2026 Eid al-Fitr confirmed date (MAR 21) Signed-off-by: akshiDhi <jamkim2224@gmail.com>

Update EID_AL_FITR confirmed year to 2026

8550906

Philippines: add 2026 Eid al-Fitr confirmed date (MAR 20) Signed-off-by: akshiDhi <jamkim2224@gmail.com>

Update EID_AL_FITR confirmed year to 2026

dbe49a3

Indonesia: add 2025-2026 Eid al-Adha confirmed dates Signed-off-by: akshiDhi <jamkim2224@gmail.com>

Update EID_AL_Adha confirmed year to 2026

cacf5a0

Philippines: add 2025-2026 Eid al-Adha confirmed dates Signed-off-by: akshiDhi <jamkim2224@gmail.com>

akshiDhi requested review from KJhellico, PPsyrius and arkid15r as code owners May 30, 2026 07:59

cubic-dev-ai Bot reviewed May 30, 2026

View reviewed changes

PPsyrius reviewed May 30, 2026

View reviewed changes

Comment thread holidays/countries/philippines.py Outdated

akshiDhi added 3 commits May 30, 2026 15:52

Philippines: add missing MAR import

8d64af1

Signed-off-by: akshiDhi <jamkim2224@gmail.com>

Philippines: fix Proclamation 1264 reference URL

29c6578

Signed-off-by: akshiDhi <jamkim2224@gmail.com>

Add my name to contributors

e8af34e

Signed-off-by: akshiDhi <jamkim2224@gmail.com>

PPsyrius reviewed May 30, 2026

View reviewed changes

Comment thread holidays/countries/indonesia.py Outdated

Comment thread holidays/countries/philippines.py Outdated

Comment thread holidays/countries/philippines.py Outdated

Comment thread holidays/countries/philippines.py Outdated

KJhellico changed the title ~~Fix: add 2025-2026 confirmed Islamic holiday dates for Indonesia and Philippines~~ Add 2025-2026 Islamic holidays exact dates for Indonesia and Philippines May 30, 2026

akshiDhi added 3 commits May 30, 2026 17:17

Indonesia: remove redundant EID_AL_ADHA dates matching default

8ab8b24

Signed-off-by: akshiDhi <jamkim2224@gmail.com>

Philippines: remove redundant EID_AL_ADHA dates matching default

3723791

Removed holiday dates for 2025 and 2026 from the Philippines. Signed-off-by: akshiDhi <jamkim2224@gmail.com>

Remove MAR from imported Gregorian months in Philippines

cdc2bdc

Signed-off-by: akshiDhi <jamkim2224@gmail.com>

coderabbitai Bot reviewed May 30, 2026

View reviewed changes

cubic-dev-ai Bot reviewed May 30, 2026

View reviewed changes

Comment thread holidays/countries/philippines.py

akshiDhi added 2 commits May 30, 2026 17:35

Indonesia: update confirmed years to 2026 for Islamic holidays

01ffee1

Signed-off-by: akshiDhi <jamkim2224@gmail.com>

Philippines: remove redundant EID_AL_FITR 2026 date matching default

161763a

Signed-off-by: akshiDhi <jamkim2224@gmail.com>

KJhellico reviewed May 30, 2026

View reviewed changes

Comment thread holidays/countries/philippines.py Outdated

Update holidays/countries/philippines.py

5209112

Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> Signed-off-by: akshiDhi <jamkim2224@gmail.com>

KJhellico previously approved these changes May 30, 2026

View reviewed changes

PPsyrius reviewed May 30, 2026

View reviewed changes

Comment thread holidays/countries/indonesia.py

Comment thread holidays/countries/philippines.py Outdated

Indonesia: add Vesak 2026 date

658ee68

Signed-off-by: akshiDhi <jamkim2224@gmail.com>

akshiDhi dismissed KJhellico’s stale review via 658ee68 May 30, 2026 14:52

Philippines: extend Lunar New Year confirmed years to 2026

962c762

Signed-off-by: akshiDhi <jamkim2224@gmail.com>

PPsyrius approved these changes May 30, 2026

View reviewed changes

KJhellico approved these changes May 30, 2026

View reviewed changes

arkid15r reviewed May 30, 2026

View reviewed changes

arkid15r added this pull request to the merge queue May 30, 2026

Merged via the queue into vacanza:dev with commit f06e031 May 30, 2026
32 checks passed

arkid15r mentioned this pull request Jun 1, 2026

v0.98 #3597

Merged

Uh oh!

Conversation

akshiDhi commented May 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Checklist

Uh oh!

coderabbitai Bot commented May 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

❌ Failed checks (2 inconclusive)

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

PPsyrius left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

akshiDhi commented May 30, 2026

Uh oh!

codecov Bot commented May 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

PPsyrius left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

akshiDhi commented May 30, 2026

Uh oh!

Uh oh!

KJhellico left a comment

Choose a reason for hiding this comment

Uh oh!

PPsyrius left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot commented May 30, 2026

Uh oh!

sonarqubecloud Bot commented May 30, 2026

Quality Gate passed

Uh oh!

KJhellico commented May 30, 2026

Uh oh!

PPsyrius left a comment

Choose a reason for hiding this comment

Uh oh!

arkid15r left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

akshiDhi commented May 30, 2026 •

edited

Loading

coderabbitai Bot commented May 30, 2026 •

edited

Loading

codecov Bot commented May 30, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading