Skip to content

Conversation

@piotrpospiech
Copy link
Collaborator

@piotrpospiech piotrpospiech commented Feb 26, 2025

Closes #1396

  • removed deprecated defaultProps from function components (migration guide)
  • changed JSX to React.JSX (migration guide)
  • added react ^19.0.0 in peerDependencies
  • updated @types/react to 19.0.10
  • added react 19 to the devDependencies as pnpm was still using v18
  • fixed TS build errors with cloneElement

Currently, tests are failing with React 19. This requires further investigation.

Test Suites: 8 failed, 28 passed, 36 total
Tests:       314 failed, 231 skipped, 1660 passed, 2205 total

Important

Failing tests are skipped right now and I added a comment before those tests to make it easier to work with them locally (commit). CI tests are no longer a valid metric.

@piotrpospiech piotrpospiech self-assigned this Feb 26, 2025
@github-project-automation github-project-automation bot moved this to Review in Open Source Feb 26, 2025
@github-actions github-actions bot added Area: Core Affects the uniforms package Area: Theme Affects some of the theme packages Area: Bridge Affects some of the bridge packages Area: Docs Affects the documentation or reproductions seed Theme: AntD Affects the uniforms-antd package Theme: Bootstrap 4 Affects the uniforms-bootstrap4 package Theme: Bootstrap 5 Affects the uniforms-bootstrap5 package Theme: MUI Affects the uniforms-mui package Theme: Semantic UI Affects the uniforms-semantic package Theme: Unstyled Affects the uniforms-unstyled package Bridge: SimpleSchema (v2) Affects the uniforms-bridge-simple-schema-2 package labels Feb 26, 2025
@codecov
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.07%. Comparing base (ba4c593) to head (2ea1125).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1398      +/-   ##
==========================================
- Coverage   95.53%   95.07%   -0.46%     
==========================================
  Files         175      175              
  Lines        2867     2865       -2     
  Branches      773      782       +9     
==========================================
- Hits         2739     2724      -15     
- Misses         59       71      +12     
- Partials       69       70       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@piotrpospiech piotrpospiech added this to the v4.x milestone Feb 27, 2025
Base automatically changed from update-testing-library to master April 9, 2025 07:12
@casasmartinignacio
Copy link

updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Bridge Affects some of the bridge packages Area: Core Affects the uniforms package Area: Docs Affects the documentation or reproductions seed Area: Theme Affects some of the theme packages Bridge: SimpleSchema (v2) Affects the uniforms-bridge-simple-schema-2 package Theme: AntD Affects the uniforms-antd package Theme: Bootstrap 4 Affects the uniforms-bootstrap4 package Theme: Bootstrap 5 Affects the uniforms-bootstrap5 package Theme: MUI Affects the uniforms-mui package Theme: Semantic UI Affects the uniforms-semantic package Theme: Unstyled Affects the uniforms-unstyled package

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

Add support to React19

3 participants