Fix #734: Add fail_on_re_record option, to raise an exception when cassette re-recorded#768
Open
mhuntglickman wants to merge 2 commits into
Open
Fix #734: Add fail_on_re_record option, to raise an exception when cassette re-recorded#768mhuntglickman wants to merge 2 commits into
mhuntglickman wants to merge 2 commits into
Conversation
krainboltgreene
suggested changes
Dec 24, 2019
| elsif InternetConnection.available? | ||
| log "re-recording (#{info})." | ||
| if @fail_on_re_record | ||
| raise RuntimeError.new("Beyond record interval. Please re_record your cassette and commit them.") |
Contributor
There was a problem hiding this comment.
Suggested change
| raise RuntimeError.new("Beyond record interval. Please re_record your cassette and commit them.") | |
| raise RuntimeError.new("The re-record interval has passed, please re_record your cassettes.") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new option
fail_on_re_record, which raises a runtime error when a cassette is re-recorded.Fixes #734