Fix: the behavior of the option re_record_interval "none"#824
Merged
olleolleolle merged 2 commits intoJul 14, 2020
Conversation
In this commit, we are changing how the option re_record_interval behaves. If this option is provided together with record mode set to none, VCR won't re-record cassettes, even if their intervals have expired. This commit solves the issue #687
olleolleolle
approved these changes
Jun 19, 2020
olleolleolle
left a comment
Member
There was a problem hiding this comment.
I think this solves the issue - while still allowing other settings than :all and :none to exist.
Contributor
Author
|
Hey @olleolleolle, what is the process to get the PR merged? Am I missing something? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pull request, we are changing how the option
re_record_intervalbehaves.If this option is provided together with
recordmode set tonone, VCR won't re-record cassettes, even if their intervals have expired.This commit solves the issue #687