Support Cucumber-Ruby v4 and later#845
Merged
Merged
Conversation
In version 4 of Cucumber-Ruby the execution of test cases is based on Pickles. Therefore less data from the feature files are available to the before/after/etc hooks. Also the Gherkin grammar has changed so that (all) Scenarios can have Examples - that is "Scenario Outline" is not just synonym for "Scenario". Therefore, in case of the "use scenario name" option, use the feature file name instead of feature name, and use the row of the example to create uniqueness for Scenarios with Examples.
andrehjr
added a commit
to andrehjr/vcr
that referenced
this pull request
Dec 28, 2021
Merged
andrehjr
added a commit
to andrehjr/vcr
that referenced
this pull request
Dec 28, 2021
olleolleolle
pushed a commit
that referenced
this pull request
Jan 2, 2022
* upgrade cucumber to 7.0 * Fix specs due to Scenario#cell_values being no longer available * Update cassette file name to match behavior introduced on #845 * Update Gemfile.cucumber to ~> 4.0 Co-authored-by: Tim Aßmann <tassmann@jovoto.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In version 4 of Cucumber-Ruby the execution of test cases is based on Pickles. Therefore less data from the feature files are available to the before/after/etc hooks. Also the Gherkin grammar has changed so that (all) Scenarios can have Examples - that is "Scenario Outline" is not just synonym for "Scenario".
Therefore, in case of the "use scenario name" option, use the feature file name instead of feature name, and use the row of the example to create uniqueness for Scenarios with Examples.
Fixes #843.