Make it possible to turn VCR on and off in a new thread#1019
Open
aglundahl wants to merge 1 commit into
Open
Conversation
olleolleolle
reviewed
Jun 5, 2025
Member
olleolleolle
left a comment
There was a problem hiding this comment.
Well, this looks handy. Does it pass tests?
3f34f59 to
2947bac
Compare
Author
Just updated my branch. Yes, the tests still pass. |
|
I think this fix would solve an issue we encounter when using VCR in combination with parallel_tests. The |
nvanoorschot
reviewed
Oct 1, 2025
35c5186 fixed so that VCR's `:turned_off` status for the main thread can be read in a new thread, even if the status changes after the new thread was created. However, the solution also introduced the problem that the `:turned_off` status isn't used for other threads than the main thread. This effectively makes it impossible to turn VCR on and off in a new thread. This change, instead, creates new contexts with `:turned_off` and `:ignore_cassettes` set to `nil` by default. When the values are read, they are only used if they explicitly have been set on the thread's context. Otherwise the main thread's context is used.
2947bac to
9bad3f3
Compare
Member
|
@aglundahl This looks fantastic. Thank you for building it. If you don't mind, could you rebase on top of latest? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#764 fixed so that VCR's
:turned_offstatus for the main thread can be read in a new thread, even if the status changes after the new thread was created.However, the solution also introduced the problem that the
:turned_offstatus isn't used for other threads than the main thread. This effectively makes it impossible to turn VCR on and off in a new thread.This change, instead, creates new contexts with
:turned_offand:ignore_cassettesset tonilby default. When the values are read, they are only used if they explicitly have been set on the thread's context. Otherwise the main thread's context is used.