-
Notifications
You must be signed in to change notification settings - Fork 1.9k
enhancement(aws_s3 sink): Add parquet codec
#17395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for vrl-playground ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vector-project ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
parquet codec
Regression Detector ResultsRun ID: 3ba1be74-2688-4cb6-95f0-9bdc49026042 ExplanationA regression test is an integrated performance test for Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval. We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:
The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed. No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%. Fine details of change detection per experiment.
|
|
Not supporting logical types LIST and MAP from the start can cause significant confusion so I'll add it. |
|
@ktff are you still working on this one? |
|
@jszwedko I am, but how I understand it it's blocked on support for batched codecs. Other than that, this PR is missing documentation and decision on how to deal with Events that don't conform to schema. |
Ah, gotcha. I'm not sure when we'll get to adding the batched codec support, but if that is something you are interested in we'd be happy to help 🙂 . |
|
Any movement on this PR? |
1720078 to
ffe54be
Compare
Closes #1374
Implementation of
parquetcodec foraws_s3sink.Usage, as with
avrocodec, definecodecasparquetand defineencoding.parquet.schema.Example:
Currently there is no enforcement of the schema before the serializer so if a single event doesn't satisfy the schema it will fail the entire batch.
Is not meant for merger, will remain in draft until batch codecs have landed. Regarding that, the serializer itself is generic, what's not so ok is the way it's woven into current codec abstractions. It can also be viewed as an example case of where the problematic spots are.
Todo/Extensions
* Try to enforce schema in the sink through
schema_requirement. Unfortunately it doesn't seem possible at the moment. The problem is in the parquet schema not having meaning for it's fields whichschema_requirementrequires.* Or, fail only invalid event not the whole batch.