Display a header line when editing annotation contents#192
Closed
astoff wants to merge 2 commits into
Closed
Conversation
Owner
|
This change looks good to me! I will test it and merge it in tomorrow. +1 to adding Thanks! |
This is consistent with other Emacs packages such as org-capture, VC, Magit, etc.
Contributor
Author
Done! |
Owner
|
Merging this in, thanks for the change! |
vedang
pushed a commit
that referenced
this pull request
Jun 10, 2023
This is consistent with other Emacs packages such as org-capture, VC, Magit, etc. Closes: #192
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using an echo area message that disappears, display the keys to commit and abort in the header line. This is similar to what org-capture does.
I could also add a customization option to keep the old behavior (but note that a more advanced user can do this anyway using
pdf-annot-edit-contents-minor-mode-hook).Finally, a tangential comment: For consistency with org-capture and magit's commit message editor,
pdf-annot-edit-contents-abortshould beC-c C-kinstead ofC-c C-q. Should we add an additional binding in the minor mode map?