Improvements to firefox-pure #15

cevdetta · 2025-08-31T12:31:55Z

Improvements overall with be

independent from X libraries, (libxss)
disable debug
enable strip
use system libraries like "png" and "pipewire".

…bug, enable strip, use system libraries like "png" and "pipewire".

TheWyn · 2025-09-01T09:58:01Z

Did you test?

cevdetta · 2025-09-02T16:49:51Z

Did you test?

It seems that I've added it: https://searchfox.org/firefox-main/source/browser/config/mozconfigs/win32/mingwclang#34
because of that but we do build it on Linux, that's why there is no option like that so we just need to remove that line.

firefox-pure/PKGBUILD

…nd enable jemalloc for performant builds

cevdetta · 2025-09-10T15:00:44Z

Proposal to add --disable-accessibility, --disable-synth-speechd and --disable-webspeech for example in order to gain performance.

Proposal to add --enable-audio-backends and explicitly state which audio backends to choose: in Wayland, it's suggested to use Pipewire, and Pipewire has alsa, pulse and jack plugins; almost always there is a need for pipewire-alsa thus it could be better to just use alsa and disable pulseaudio too. According to Gentoo Wiki Firefox : PulseAudio (Rust) has Tier-1 support whereas Alsa and Jack have Tier-3, we already disabled jack it'd be better to just use alsa or we can consider to use pulseaudio?

firefox-pure/PKGBUILD

Co-authored-by: Vasiliy Stelmachenok <92667539+ventureoo@users.noreply.github.com>

…able 'pulseaudio': - Remove '--enable-clang-plugin', not needed, it's for static analysis. - Remove duplicated declaration of '--enable-optimize', because afterwards it's already declared as '--enable-optimize=-O3'. - Enable 'pulseaudio' because 'pulse-rust' has the Tier-1 support and until there is support for Pipewire, it's the best we've apart from 'alsa'. - Change '--enable-application' to '--enable-project' because it's the [new default that is used by Mozilla](mozilla-firefox/firefox@432b8b8). - Add '--disable-rust-tests' alongside with '--disable-tests'. - Remove support for Windows specific things with '--disable-wmf' and '--disable-negotiateauth'. - Remove support for legacy behaviour with '--disable-legacy-profile-creation'. - Add '--disable-accessibility' for performance. - Add '--disable-webdriver' to disable remote stuff. - Add '--disable-real-time-tracing' to disable tracking. - Add '--disable-gecko-profiler' to disable profiler inside Firefox.

firefox-pure/PKGBUILD

ventureoo · 2025-09-11T19:06:43Z

Except PipeWire thing, build works fine and I haven't noticed any regressions yet.

cevdetta · 2025-09-11T21:41:24Z

Except PipeWire thing, build works fine and I haven't noticed any regressions yet.

Awesome, can you check the difference (build times, binary size, and maybe a web benchmark) ?

ventureoo · 2025-09-12T07:36:11Z

Except PipeWire thing, build works fine and I haven't noticed any regressions yet.

Awesome, can you check the difference (build times, binary size, and maybe a web benchmark) ?

I made a build without v3, so it probably doesn’t make any sense to compare yet. Please push removal of system pipewire so I can start CI and get the artifact for us.

cevdetta · 2025-09-12T07:56:56Z

Except PipeWire thing, build works fine and I haven't noticed any regressions yet.

Awesome, can you check the difference (build times, binary size, and maybe a web benchmark) ?

I made a build without v3, so it probably doesn’t make any sense to compare yet. Please push removal of system pipewire so I can start CI and get the artifact for us.

Done.

ventureoo · 2025-09-12T13:21:00Z

Except PipeWire thing, build works fine and I haven't noticed any regressions yet.

Awesome, can you check the difference (build times, binary size, and maybe a web benchmark) ?

I made a build without v3, so it probably doesn’t make any sense to compare yet. Please push removal of system pipewire so I can start CI and get the artifact for us.

Done.

Package size reduced a bit, compilation time on CI has not changed.

Package (1)   Old Version  New Version  Net Change

firefox-pure  142.0.1-1    142.0.1-1     -9.26 MiB

Total Installed Size:  246.02 MiB
Net Upgrade Size:       -9.26 MiB

Also please bump new pkgver both in PKGBUILD and .SRCINFO, then I can merge it.

cevdetta · 2025-09-12T16:10:59Z

Except PipeWire thing, build works fine and I haven't noticed any regressions yet.

Awesome, can you check the difference (build times, binary size, and maybe a web benchmark) ?

I made a build without v3, so it probably doesn’t make any sense to compare yet. Please push removal of system pipewire so I can start CI and get the artifact for us.

Done.

Package size reduced a bit, compilation time on CI has not changed.
Package (1)   Old Version  New Version  Net Change

firefox-pure  142.0.1-1    142.0.1-1     -9.26 MiB

Total Installed Size:  246.02 MiB
Net Upgrade Size:       -9.26 MiB
Also please bump new pkgver both in PKGBUILD and .SRCINFO, then I can merge it.

pkgver or pkgrel? and if pkgver should I change it from 142.0.1 to 142.0.1-1? or should I change pkgrel from 1 to 2?

ventureoo · 2025-09-12T16:49:26Z

Except PipeWire thing, build works fine and I haven't noticed any regressions yet.

Awesome, can you check the difference (build times, binary size, and maybe a web benchmark) ?

I made a build without v3, so it probably doesn’t make any sense to compare yet. Please push removal of system pipewire so I can start CI and get the artifact for us.

Done.

Package size reduced a bit, compilation time on CI has not changed.
Package (1)   Old Version  New Version  Net Change

firefox-pure  142.0.1-1    142.0.1-1     -9.26 MiB

Total Installed Size:  246.02 MiB
Net Upgrade Size:       -9.26 MiB
Also please bump new pkgver both in PKGBUILD and .SRCINFO, then I can merge it.
pkgver or pkgrel? and if pkgver should I change it from 142.0.1 to 142.0.1-1? or should I change pkgrel from 1 to 2?

Yeah, I meant pkgrel.

cevdetta · 2025-09-12T17:02:16Z

Except PipeWire thing, build works fine and I haven't noticed any regressions yet.

Awesome, can you check the difference (build times, binary size, and maybe a web benchmark) ?

I made a build without v3, so it probably doesn’t make any sense to compare yet. Please push removal of system pipewire so I can start CI and get the artifact for us.

Done.

Package size reduced a bit, compilation time on CI has not changed.
Package (1)   Old Version  New Version  Net Change

firefox-pure  142.0.1-1    142.0.1-1     -9.26 MiB

Total Installed Size:  246.02 MiB
Net Upgrade Size:       -9.26 MiB
Also please bump new pkgver both in PKGBUILD and .SRCINFO, then I can merge it.
pkgver or pkgrel? and if pkgver should I change it from 142.0.1 to 142.0.1-1? or should I change pkgrel from 1 to 2?
Yeah, I meant pkgrel.

Done.

ventureoo

LGTM, thank you and sorry for the long review!

Improvements overall with be independent from X libraries, disable de…

07bb8d1

…bug, enable strip, use system libraries like "png" and "pipewire".

Remove "disable-update-agent" because it's only on Windows builds.

71ab385

ventureoo requested changes Sep 5, 2025

View reviewed changes

firefox-pure/PKGBUILD Outdated Show resolved Hide resolved

firefox-pure/PKGBUILD Show resolved Hide resolved

firefox-pure/PKGBUILD Outdated Show resolved Hide resolved

cevdetta added 2 commits September 6, 2025 20:58

Remove 'png' from system libraries until APNG support arrives.

c1f31ab

Remove --disable-xcb

a6c501f

ventureoo requested changes Sep 9, 2025

View reviewed changes

firefox-pure/PKGBUILD Outdated Show resolved Hide resolved

firefox-pure/PKGBUILD Outdated Show resolved Hide resolved

Remove 'xlib' and 'ps', in addition disable cargo incremental build a…

d1b9150

…nd enable jemalloc for performant builds

ventureoo requested changes Sep 11, 2025

View reviewed changes

firefox-pure/PKGBUILD Outdated Show resolved Hide resolved

firefox-pure/PKGBUILD Show resolved Hide resolved

cevdetta and others added 2 commits September 11, 2025 14:55

Remove '--disable-debug-mode'

7a42eb2

Co-authored-by: Vasiliy Stelmachenok <92667539+ventureoo@users.noreply.github.com>

cevdetta requested a review from ventureoo September 11, 2025 14:20

ventureoo reviewed Sep 11, 2025

View reviewed changes

firefox-pure/PKGBUILD Show resolved Hide resolved

firefox-pure/PKGBUILD Outdated Show resolved Hide resolved

Remove "libpipewire"

d497ce1

Bump pkgrel to 2, remove libxss from SRCINFO

187cd72

ventureoo approved these changes Sep 12, 2025

View reviewed changes

ventureoo merged commit 6d13090 into ventureoo:main Sep 12, 2025

Improvements to firefox-pure #15

Improvements to firefox-pure #15

Uh oh!

Conversation

cevdetta commented Aug 31, 2025

Uh oh!

TheWyn commented Sep 1, 2025

Uh oh!

cevdetta commented Sep 2, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cevdetta commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ventureoo commented Sep 11, 2025

Uh oh!

cevdetta commented Sep 11, 2025

Uh oh!

ventureoo commented Sep 12, 2025

Uh oh!

cevdetta commented Sep 12, 2025

Uh oh!

ventureoo commented Sep 12, 2025

Uh oh!

cevdetta commented Sep 12, 2025

Uh oh!

ventureoo commented Sep 12, 2025

Uh oh!

cevdetta commented Sep 12, 2025

Uh oh!

ventureoo left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cevdetta commented Sep 10, 2025 •

edited

Loading