headers: validate CWT claims#210
Open
pranjalkole wants to merge 2 commits into
Open
Conversation
Contributor
|
@veraison/go-cose-maintainers, can we get some 👀's on this? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
==========================================
- Coverage 91.12% 89.18% -1.95%
==========================================
Files 12 12
Lines 2006 2053 +47
==========================================
+ Hits 1828 1831 +3
- Misses 122 168 +46
+ Partials 56 54 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shizhMSFT
reviewed
Feb 8, 2025
Signed-off-by: Pranjal Kole <pranjal.kole7@gmail.com>
OR13
approved these changes
Apr 11, 2025
Contributor
|
@shizhMSFT, @qmuntal, @thomas-fossati can you PTAL? |
shizhMSFT
reviewed
Apr 11, 2025
Co-authored-by: Shiwei Zhang <shizh@microsoft.com> Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>
Contributor
|
@pranjalkole can you please take a look at above changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We could also refactor this to a
validateCWTClaimsfunction incwt.go