fix: Split image versions from URLs to make overriding easier #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnaser
requested changes
Nov 15, 2024
8420e3b to
5be2398
Compare
Contributor
Author
|
@mnaser just a reminder on this one and the similar ansible-collection-kubernetes patch if you have time. |
mnaser
pushed a commit
that referenced
this pull request
Aug 26, 2025
🤖 I have created a release *beep* *boop* --- ## [1.4.4](v1.4.3...v1.4.4) (2025-08-26) ### Bug Fixes * add missing override_command in molecule.yml configuration 🐛 ([69d98b4](69d98b4)) * add missing runtime dependency ([f498458](f498458)) * add missing volume mapping for /lib/modules in molecule config 🐛 ([d46c1d2](d46c1d2)) * add pre_build_image option for molecule instance configuration 🐛 ([6f5c66f](6f5c66f)) * add prepare.yml for host preparation and apt cache update 🐛 ([a756a6d](a756a6d)) * add tmpfs configuration for containerd in molecule.yml 🐛 ([b1f7f65](b1f7f65)) * add ubuntu2004 to the nerdctl job matrix configuration 🐛 ([ac72336](ac72336)) * correct command for running Molecule tests ([5f618b2](5f618b2)) * correct condition for apt cache update to use ansible_os_family 🐛 ([5261b9d](5261b9d)) * remove become directive from converge, prepare, and verify tasks 🐛 ([944b9f0](944b9f0)) * remove deprecated version 8 from matrix in CI workflow 🐛 ([f679c6a](f679c6a)) * remove rockylinux10 from the molecule job matrix configuration 🐛 ([00f0e3e](00f0e3e)) * Split image versions from URLs to make overriding easier ([#32](#32)) ([9e33f65](9e33f65)) * update ansible-lint version to v25.6.1 ([1a3068d](1a3068d)) * update MOLECULE_DISTRO_ID to ubuntu for molecule tests 🐛 ([9541c0e](9541c0e)) * update prepare.yml to use tasks instead of roles for apt cache 🐛 ([5912dcd](5912dcd)) * update tmpfs and volumes configuration in molecule.yml 🐛 ([07af3d9](07af3d9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the version out into a separate variable from image URLs. In doing so, when it is necessary to override image URLs to reference an offline registry, we can reference the image version(s) which match the version of this collection which we are pinning to.