Skip to content

Fixes some errors in the v0.3dev #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shagunsodhani wants to merge 2 commits into
base: v0.3dev
Choose a base branch
from
Open

Fixes some errors in the v0.3dev #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e270ac3
Raise a warning if r3m module is not found
shagunsodhani Apr 26, 2022
044aa3c
Fix erros related to variable naming and overriding attributes in spec
shagunsodhani Apr 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion mj_envs/envs/env_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,11 @@
from os import path
import skvideo.io

from r3m import load_r3m
import warnings
try:
from r3m import load_r3m
except ModuleNotFoundError:
warnings.warn("r3m module not found. The module is used by some encoders.", UserWarning)

# TODO
# remove rwd_mode
Expand Down
12 changes: 6 additions & 6 deletions mj_envs/envs/env_variants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,20 +40,20 @@ def register_env_variant(env_id, variants, variant_id=None, silent=False):
del variants['max_episode_steps']

# merge specs._kwargs with variants
env_variant_specs._kwargs, variants_update_keyval_str = update_dict(env_variant_specs._kwargs, variants)
env_variant_specs._kwargs, variants_update_keyval_str = update_dict(env_variant_specs.kwargs, variants)
env_variant_id += variants_update_keyval_str

# finalize name and register env
env_variant_specs.id = env_variant_id+env_variant_specs.id[-3:] if variant_id is None else variant_id
env_variant_specs_id = env_variant_id+env_variant_specs.id[-3:] if variant_id is None else variant_id
register(
id=env_variant_specs.id,
entry_point=env_variant_specs._entry_point,
id=env_variant_specs_id,
entry_point=env_variant_specs.entry_point,
max_episode_steps=env_variant_specs.max_episode_steps,
kwargs=env_variant_specs._kwargs
)
if not silent:
print("Registered a new env-variant:", env_variant_specs.id)
return env_variant_specs.id
print("Registered a new env-variant:", env_variant_specs_id)
return env_variant_specs_id


# Example usage
Expand Down