Skip to content

Conversation

@Danthewaann
Copy link
Contributor

If test#neovim#term_position is set to something like botright 10 to setup a terminal that is 10 in height and we need to reopen the terminal since it isn't visible, the current s:neovim_reopen_term() function doesn't correctly re-open the terminal with the appropriate height. This PR addresses this by running something like botright 10 new | buffer [bufnr] which sets the height correctly instead of botright 10 sbuffer [bufnr] which doesn't.

Make sure these boxes are checked before submitting your pull request:

  • Add fixtures and spec when implementing or updating a test runner
  • Update the README accordingly
  • Update the Vim documentation in doc/test.txt

Copy link
Collaborator

@codeinabox codeinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution and the detailed explanation!

@codeinabox codeinabox merged commit 5de3bff into vim-test:master Dec 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants