Fix term_position usage in s:neovim_reopen_term #828
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
test#neovim#term_positionis set to something likebotright 10to setup a terminal that is 10 in height and we need to reopen the terminal since it isn't visible, the currents:neovim_reopen_term()function doesn't correctly re-open the terminal with the appropriate height. This PR addresses this by running something likebotright 10 new | buffer [bufnr]which sets the height correctly instead ofbotright 10 sbuffer [bufnr]which doesn't.Make sure these boxes are checked before submitting your pull request:
doc/test.txt