add function-parameters contrib_syntax / install extensions if in after#266
add function-parameters contrib_syntax / install extensions if in after#266borisdaeppen wants to merge 2 commits into
Conversation
|
Hello, I hope it's okay that both commits are in the same pull request. commit: add function-parameters contrib_syntax commit: also install extensions if in after and moose and dance will also get installed. |
|
Please let me know if it is actually desirable to use Thx for any feedback to this PR |
|
Hi @borisdaeppen! Thanks for the contribution, but I do have some reservations about the |
|
I don't mind. I already thought myself, the solution might not be optimal. Might I ask if you see any validity in the basic idea? How about a separate rule e.g. installcontrib? I would appreciate if you could formulate your reservations, if possible. So that I can improve the commit. |
|
@borisdaeppen I think the base idea is ok - my main reservations come from one make rule setting up an To be honest, now that Vim itself has a package manager, I kind of question the value of the makefile at all, except for maintainer-level tasks like building a distribution tarball or running the tests. |
| $ ls after/syntax/perl | ||
| dancer.vim moose.vim | ||
|
|
||
| This local copy of after will be concidered by a later `make install` |
No description provided.