Adjust message e_member_is_not_writable_str to include more info.
#13136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `member` to `variable`; include class in msg; quote program names.
E1335: Variable "value" in class "C" is not writable
previously
E1335: Member is not writable: value
E46: Cannot change read-only variable "value"
Contributor
Author
e_member_is_not_writable_str to include more info.
This was referenced Sep 21, 2023
Contributor
Author
|
Don't include the word class in quotes. The message now looks like as suggested in #13135 (comment) |
Member
|
The change looks good to me. |
yegappan
approved these changes
Sep 21, 2023
Contributor
Author
OK. I'll fix the tests to account for the new message, then take it out of draft. Feedback on initial message of #13135 and examples in #13135 (comment) ? |
Codecov Report
@@ Coverage Diff @@
## master #13136 +/- ##
==========================================
- Coverage 82.13% 82.13% -0.01%
==========================================
Files 160 160
Lines 195268 195268
Branches 43821 43821
==========================================
- Hits 160386 160383 -3
- Misses 22046 22057 +11
+ Partials 12836 12828 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
membertovariable; include class in msg; quote program names. Message based on comments from #13068 and #13135.Update
E1335tofrom
Change one use of
E46toE1335