This repository was archived by the owner on Oct 23, 2024. It is now read-only.
New Drawer / Sidebar #285
Draft
New Drawer / Sidebar #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| children, | ||
| }: DrawerProps) => { | ||
| return ( | ||
| <AnimatePresence> |
Collaborator
There was a problem hiding this comment.
We can give this an exitBeforeEnter prop so the exit animation can happen before framer removes the element from the dom.
| // finalFocusRef, | ||
| // returnFocusOnClose, | ||
| // preserveScrollBarGap, | ||
| children, |
Collaborator
There was a problem hiding this comment.
We can add a spread prop and pass it to motion.div to expose motion props to the parent.
const DrawerComponent = ({
...,
children,
...motionProps
}: DrawerProps & MotionProps) => {
return (
<motion.div {...motionProps}>
)
}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Experimenting with a new sidebar and drawer components using some more modern and composable patterns
Testing
https://vimeo.github.io/iris/sb/sidebar-hotness/?path=/story/components-drawer