Adding windows support for the In-place Pod Vertical Scaling feature #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Define ContainerResizePolicy and add it to Container struct. 2. Add ResourcesAllocated and Resources fields to ContainerStatus struct. 3. Define ResourcesResizeStatus and add it to PodStatus struct. 4. Add InPlacePodVerticalScaling feature gate and drop disabled fields. 5. ResizePolicy validation & defaulting and Resources mutability for CPU/Memory. KEP: /enhancements/keps/sig-node/1287-in-place-update-pod-resources
KEP: /enhancements/keps/sig-node/1287-in-place-update-pod-resources
1. Core Kubelet changes to implement In-place Pod Vertical Scaling. 2. E2E tests for In-place Pod Vertical Scaling. KEP: /enhancements/keps/sig-node/1287-in-place-update-pod-resources Co-authored-by: Chen Wang <Chen.Wang1@ibm.com>
1. Refactor kubelet code and add missing tests (Derek's kubelet review) 2. Add a new hash over container fields without Resources field to allow feature gate toggling without restarting containers not using the feature. 3. Fix corner-case where resize A->B->A gets ignored 4. Remove spurious 'ContainerResources' in Update request. 5. Add guidance/expectation from runtime in handling UpdateContainerResources CRI API. 6. Add cgroup v2 support to pod resize E2E test.
Created the feature TODOs for Windows support
501cfaa to
457644a
Compare
58824b6 to
f5a9480
Compare
f5a9480 to
815ebf2
Compare
|
Let's pursue this directly with the main branch. I believe 112599 will supercede this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
It adds the Windows support for the In-place Pod Vertical Scaling feature by solving some of the TODOs.
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
[FEATURE]: In-place Pod Vertical Scaling