feat: Add Cisco Agent Connect Protocol (ACP) support - Triple Protocol Framework #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ACP domain models (Agent, AgentRun, Thread, etc.) following ACP specification - Implement ACPRestController with full REST API endpoints for agent discovery and execution - Add ACPMapper utility for converting between A2A and ACP domain models - Create comprehensive unit tests for all ACP functionality (ACPRestControllerTest, ACPIntegrationTest, etc.) - Update CallBackType enum to include ACP alongside A2A and MCP - Add Spring Boot Web dependencies for REST controller support - Update README.MD to reflect triple protocol support (A2A, MCP, ACP) - Create MULTI_PROTOCOL_SUPPORT.md with comprehensive examples for all three protocols - Maintain full backward compatibility - all existing A2A/MCP functionality preserved - All tests passing - no regressions introduced This makes a2ajava the most comprehensive Java agent framework supporting: - A2A (JSON-RPC) for app-to-app communication - MCP (JSON-RPC) for LLM integration - ACP (REST) for enterprise agent orchestration Agents written with @Agent/@action annotations now work seamlessly across all three protocols. Co-Authored-By: Vishal Mysore <visrow@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
- Update enum constants to follow SCREAMING_SNAKE_CASE convention (PENDING, SUCCESS, IDLE, BUSY, etc.) - Replace Stream.collect(Collectors.toList()) with Stream.toList() for Java 17 compatibility - Add explicit parameter names to @PathVariable annotations for better maintainability - Update all enum references in implementation and test files These changes address the 15 SonarCloud reliability issues causing the C rating, improving code quality and following Java best practices. Co-Authored-By: Vishal Mysore <visrow@gmail.com>
- Change @PathVariable("agentId") to @PathVariable for agentId parameters - Change @PathVariable("threadId") to @PathVariable for threadId parameter - Follow established pattern from TicketTaskController.java - Addresses SonarCloud java:S6856 rule violations for @PathVariable binding Co-Authored-By: Vishal Mysore <visrow@gmail.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add Cisco Agent Connect Protocol (ACP) support - Triple Protocol Framework
Summary
This PR adds comprehensive support for Cisco's Agent Connect Protocol (ACP) to the a2ajava framework, making it the first Java framework to support all three major agent protocols: A2A (JSON-RPC), MCP (JSON-RPC), and ACP (REST).
Key additions:
/acp/*routes)The implementation leverages existing
@Agent/@Actionannotations, so developers can write agents once and have them work across all three protocols automatically.Review & Testing Checklist for Human
🔴 HIGH PRIORITY (3 items)
ACP Specification Compliance: Verify REST endpoints and domain models match the official Cisco ACP specification. The implementation follows my understanding but needs validation against real ACP clients.
Integration Testing: Test with actual ACP clients to ensure real-world compatibility. Current tests use mocks extensively and may miss integration issues.
Backward Compatibility: Run comprehensive tests to ensure existing A2A and MCP functionality works unchanged. While tests pass, the addition of Spring Web dependencies could have side effects.
Test Plan Recommendations:
/acp/agents/search,/acp/runs, etc.)@Agent/@Actionimplementations work correctly via A2A JSON-RPC, MCP, and ACP REST callsNotes