leverage caching for rendering traces #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously it was possible to load a cached file and run it without a
runtime but then fail to render its content in the trace printed to
stderr:
error! call trace (oldest first):
┆ <fs>/project.bass:35:2..35:45
35 │ (github:check-hook event client git checks))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
┆ <thunk: (.git) name:yPieviqhlsa6uTBhT-gpoQDbzpMyl1owqphA_l6wt0Y=>/bass/github.bass:3:4..54:66
! could not open frame source: no runtime configured for os=linux, arch=any
┆ (6 internal calls elided)
┆ <thunk: (.git) name:yPieviqhlsa6uTBhT-gpoQDbzpMyl1owqphA_l6wt0Y=>/bass/github.bass:5:6..17:68
! could not open frame source: no runtime configured for os=linux, arch=any
┆ (6 internal calls elided)
┆ <thunk: (.git) name:yPieviqhlsa6uTBhT-gpoQDbzpMyl1owqphA_l6wt0Y=>/bass/github.bass:9:8..9:71
! could not open frame source: no runtime configured for os=linux, arch=any
┆ <thunk: (.git) name:yPieviqhlsa6uTBhT-gpoQDbzpMyl1owqphA_l6wt0Y=>/bass/github.bass:57:4..59:27
! could not open frame source: no runtime configured for os=linux, arch=any
no runtime configured for os=linux, arch=any
now if it's able to get that far it'll use the cached file for rendering
the actual code, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously it was possible to load a cached file and run it without a runtime but then fail to render its content in the trace printed to stderr:
live example here
now if it's able to get that far it'll use the cached file for rendering the actual code too.