Skip to content

Conversation

@vito
Copy link
Owner

@vito vito commented Nov 27, 2022

  • don't commit test TLS certs to repo, generate on-the-fly instead
    • tests started failing because the committed certs expired (duh)
  • rotate local depot certs automatically
  • refactor secrets/interruption tests to match the rest of the test setup
  • misc test cleanups/fixes

vito added 10 commits November 26, 2022 20:59
these all share a session, so mutating *stdin* from the loaded module
would result in the second test failing
previously progress output wasn't being captured and displayed by
failing Dagger tests because for Dagger the progress is emitted at the
pool-level, which was constructed ahead of the progress UI being wired
up.

this simplifies the individual runtime tests since they just need to
pass a single runtime config in, but I'd still prefer to not have a
monolithic progress sink. oh well. maybe that'll improve when we figure
out the progress API in Dagger.
* generate tls certs on every suite run
* remove static tls certs which were also installed into docker
  container
* tests create their own installation with the generated cert instead

note that the cert being out of date isn't detected; you'll need to
docker rm -f the test container still
@vito vito added the bugfix Fixes a regression or unintended behavior label Nov 27, 2022
@vito vito merged commit 525802f into main Nov 27, 2022
@vito vito deleted the rotate-refactor-tls branch November 27, 2022 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixes a regression or unintended behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants