Skip to content

Commit 37c2401

Browse files
fix(browser): prebundle vite module runner with vitest (fix #10836) (#10856)
Co-authored-by: Vladimir <sleuths.slews0s@icloud.com>
1 parent 3cf27ed commit 37c2401

2 files changed

Lines changed: 16 additions & 2 deletions

File tree

packages/browser/src/node/index.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -456,11 +456,9 @@ function resolveBrowserOptimizeDeps(
456456
// - vitest/browser, @vitest/browser/context, @vitest/browser/utils are
457457
// VIRTUAL modules generated per-server (see pluginContext.ts) — optimizer
458458
// cannot resolve/run their `load`, it would freeze stale/empty content.
459-
// - vite/module-runner is small enough to not need pre-bundling.
460459
// - msw is a large, side-effectful service-worker library.
461460
const exclude = [
462461
'vitest/browser',
463-
'vite/module-runner',
464462
'@vitest/browser/utils',
465463
'@vitest/browser/context',
466464
'msw',
@@ -504,6 +502,7 @@ function resolveBrowserOptimizeDeps(
504502
'vitest > expect-type',
505503
'vitest > magic-string',
506504
'vitest > chai',
505+
'vitest > vite/module-runner',
507506
'vitest',
508507
'vitest/internal/browser',
509508
'@vitest/browser/client',

test/e2e/test/config/browser-configs.test.ts

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,21 @@ test('does not disable pre-transform requests in browser mode', async () => {
105105
})
106106
})
107107

108+
test('pre-bundles vite module runner through vitest in browser mode', async () => {
109+
const v = await vitest({
110+
browser: {
111+
enabled: true,
112+
provider: preview(),
113+
instances: [
114+
{ browser: 'chromium' },
115+
],
116+
},
117+
})
118+
119+
expect(v.vite.config.optimizeDeps.include).toContain('vitest > vite/module-runner')
120+
expect(v.vite.config.optimizeDeps.exclude).not.toContain('vite/module-runner')
121+
})
122+
108123
test('disables pre-transform requests in node mode', async () => {
109124
expect(await observePreTransformRequests()).toEqual({
110125
client: false,

0 commit comments

Comments
 (0)