MemObjFile parsing fixes #665
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itial size to offset tweaks: added concept of the file's maps, and the "end", as well as giving seek() the "whence" option. whence et al were added from an older stash, written before the rest... it's possible we want to merge the two things better.
rakuy0
requested changes
Aug 17, 2024
vstruct/__init__.py
Outdated
| size = msize - self.offset | ||
| offset = 0 | ||
|
|
||
| while True: |
Contributor
There was a problem hiding this comment.
Similar to getSize, is there a reason you calculate self.basemaps but then never use it? Are you expecting the maps to change (and if so, is there a way we can keep state in sync so we can simply a lot of this checking)?
Contributor
Author
There was a problem hiding this comment.
TODO: access self.basemaps
vstruct/__init__.py
Outdated
| offset += msize | ||
|
|
||
| if osize is None: | ||
| logger.info("read() reading from 0x%x: 0x%x", self.baseaddr + self.offset, size) |
Contributor
There was a problem hiding this comment.
Is there a reason this is a separate conditional instead of being under if size is None?
atlas0fd00m
commented
Aug 22, 2024
Co-authored-by: atlas0fd00m <atlas@r4780y.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently MemObjFile is decentish for loading PE's from memory/vsnapshots.
supporting ELF will take some reworking, as the PE maps tend to be adjacent, whereas some architectures like to space ELF maps out by a couple MB of virtual address space