Skip to content
This repository was archived by the owner on Mar 26, 2024. It is now read-only.

Add option for incremental build#100

Open
rgaiacs wants to merge 2 commits into
vladris:masterfrom
rgaiacs:incremental
Open

Add option for incremental build#100
rgaiacs wants to merge 2 commits into
vladris:masterfrom
rgaiacs:incremental

Conversation

@rgaiacs
Copy link
Copy Markdown

@rgaiacs rgaiacs commented Jul 6, 2016

Close #90.

@rgaiacs
Copy link
Copy Markdown
Author

rgaiacs commented Sep 10, 2016

@vladris Do you have interest on this?

@vladris
Copy link
Copy Markdown
Owner

vladris commented Sep 13, 2016

Thanks for the PR!

If I remember correctly, the reason I didn't initially support incremental build was that a bunch of stuff gets generated after all posts have been processed - things like content and metadata on the home page, the Archive, the RSS feed etc. Did you make sure all of these get properly updated with --incremental flag? When I initially implemented this I couldn't figure out a good way of updating all the required information with an incremental build.

@rgaiacs
Copy link
Copy Markdown
Author

rgaiacs commented Sep 13, 2016

If I remember correctly, the reason I didn't initially support incremental build was that a bunch of stuff gets generated after all posts have been processed - things like content and metadata on the home page, the Archive, the RSS feed etc. Did you make sure all of these get properly updated with --incremental flag? When I initially implemented this I couldn't figure out a good way of updating all the required information with an incremental build.

I didn't check. But I need the incremental build for check my post otherwise takes a couple of minutes to rebuild since I have many photos on my blog and all the images will need to be copied again.

@vladris
Copy link
Copy Markdown
Owner

vladris commented Sep 13, 2016

That makes sense actually. I would call it "partial" though instead of "incremental" to make it clear that we probably want a full build before publishing. Maybe also print a message after the build to make this clear. If you update the PR with this and make sure Travis build succeeds, I'll merge it. Thanks again for your interest in Tinkerer!

@rgaiacs
Copy link
Copy Markdown
Author

rgaiacs commented Sep 14, 2016

If you update the PR with this and make sure Travis build succeeds, I'll merge it.

Thanks. :-) I will work on that in the next two weeks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants