Skip to content

Conversation

@Gamemechanicwow
Copy link
Contributor

🍰 Pullrequest

filterLedgeSpans:
Changed variable names in filterLedgeSpans to reflect names in recast.
Removed unnecessary std::lists

Other minor stuff:
Changed 0 to AREA_NONE were applicable.
Fixed logic in getGridBounds to calculate correct bounds if there are only liquid verts

Proof

  • None

Issues

  • None

How2Test

  • None

Todo / Checklist

  • None

@ratkosrb ratkosrb merged commit 15b22de into vmangos:development Sep 20, 2023
@Gamemechanicwow Gamemechanicwow deleted the movemapgen-030923 branch September 20, 2023 20:43
@icedcolor
Copy link

After this modification, the map extracted by the extractor will lose 0343132.mmtile, resulting in monsters from Stormwind Prison not attacking the player and evading the behavior.

@Gamemechanicwow
Copy link
Contributor Author

After this modification, the map extracted by the extractor will lose 0343132.mmtile, resulting in monsters from Stormwind Prison not attacking the player and evading the behavior.

I don't believe this PR is the cause of your issue 🤔

I can't see how this could have any impact on tiles not being generated. The mentioned tile is generated when I try.

@icedcolor
Copy link

Hello, can you send me the four map generators you generated? Thank you!

@Gamemechanicwow
Copy link
Contributor Author

Hello, can you send me the four map generators you generated? Thank you!

You can download the newest binaries here https://github.com/vmangos/core/releases

@w5860363
Copy link
Contributor

w5860363 commented Oct 7, 2023

@Gamemechanicwow Confirm that when the extractor is not set to high resolution, mmap is missing 0343132.mmtile

At the same time, the console reported error mmap.not found 0343132.mmtile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants