Revert "fix: Node resource topology awareness, stop scheduling and notReady" #4575
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @dafu-wu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request reverts a previous change (PR #4373) that introduced logic to exclude unschedulable or not-ready nodes from the total resource calculation within the scheduler's session. The revert ensures consistency in how realCapacity and allocated resources are calculated, by including all nodes regardless of their schedulability or readiness status, thus preventing discrepancies in resource accounting.
Highlights
- Revert of Node Exclusion Logic: The core change is the reversal of a previous modification that prevented unschedulable or not-ready nodes from contributing to the TotalResource calculation in the scheduler's session.
- Removal of Helper Functions: The isNodeUnschedulable and isNodeNotReady utility functions, which were used to identify and filter out specific node states, have been removed.
- Deletion of Related Tests: The unit tests specifically designed for the removed node state checking functions (util_test.go) have been entirely removed.
- Test Utility Adjustment: The BuildNode helper in test utilities no longer explicitly sets a NodeReady condition, aligning with the removal of node readiness checks in resource aggregation.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request reverts a previous change that introduced checks for node readiness and schedulability when calculating total cluster resources. The revert is well-justified in the description, aiming to restore consistency in resource calculations. The changes are clean and correctly remove the relevant logic, helper functions, and associated tests. The removal of the default NodeReady condition in the BuildNode test utility is also consistent with the revert. Overall, this is a good and necessary change to address the inconsistency introduced by the original commit.
…tReady" Signed-off-by: dafu <wuchengyi2006@163.com>
03c1f31 to
af0f18a
Compare
|
@Monokaix Can you help review and approve it? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Monokaix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Reverts #4373
The reason is that the criteria for calculating realCapacity and allocated should be consistent — either both should take unschedulable nodes into account, or neither should. For details, see PR #4562