Tune Command#8
Merged
Merged
Conversation
f03cc4b to
dfafe09
Compare
added 4 commits
March 10, 2020 08:42
Signed-off-by: Simon Rüegg <simon.ruegg@vshn.ch>
According to the default setup of cobra. Signed-off-by: Simon Rüegg <simon.ruegg@vshn.ch>
Signed-off-by: Simon Rüegg <simon.ruegg@vshn.ch>
Signed-off-by: Simon Rüegg <simon.ruegg@vshn.ch>
ba00d7c to
97bf3a4
Compare
ccremer
reviewed
Mar 11, 2020
To query Elasticsearch by unique-id.
Generate exclusion rules based on unique IDs.
ccremer
suggested changes
Mar 16, 2020
ccremer
reviewed
Mar 16, 2020
As stated by the go wiki [1]. [1] https://github.com/golang/go/wiki/CodeReviewComments#error-strings Signed-off-by: Simon Rüegg <simon@rueggs.ch>
By introducing a type alias for the used map. Signed-off-by: Simon Rüegg <simon@rueggs.ch>
As stated in [1] "when in doubt, use a pointer receiver". [1] https://github.com/golang/go/wiki/CodeReviewComments#receiver-type Signed-off-by: Simon Rüegg <simon@rueggs.ch>
ccremer
suggested changes
Mar 17, 2020
ccremer
suggested changes
Mar 18, 2020
ccremer
left a comment
Contributor
There was a problem hiding this comment.
one last thing, then it's LGTM
ccremer
reviewed
Mar 18, 2020
Various improvements. Signed-off-by: Simon Rüegg <simon@rueggs.ch>
To improve the readability of the tests. Signed-off-by: Simon Rüegg <simon@rueggs.ch>
Move the setup up of the Elasticsearch client to a method. Signed-off-by: Simon Rüegg <simon.ruegg@vshn.ch>
ccremer
approved these changes
Mar 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a tune command which generates ModSecurity rule exclusions, based on a unique ID.
The unique ID is queried for in Elasticsearch and exclusions are generated for all found ModSecurity alerts.