adding intentional fail of style check#11
Conversation
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
|
@spackbot hello |
|
👋️ |
|
It looks like you had an issue with style checks! To fix this, you can run: $ spack style --fixAnd then update the pull request here. |
|
@spackbot commands |
|
You can interact with me in many ways!
I'll also help to label your pull request and assign reviewers! |
|
@spackbot hello! |
|
こんにちは！ |
|
@spackbot commands |
|
You can interact with me in many ways!
I'll also help to label your pull request and assign reviewers! |
|
@spackbot fix style! |
|
I cannot do that for you yet, Vanessa. |
|
Let me see if I can fix that for you! |
|
@spackbot fix style! |
|
Let me see if I can fix that for you! This might take a moment... |
|
@spackbot fix style |
This comment has been minimized.
This comment has been minimized.
|
Let me see if I can fix that for you! This might take a moment... |
1 similar comment
|
Let me see if I can fix that for you! This might take a moment... |
|
@spackbot fix style |
|
Let me see if I can fix that for you! This might take a moment... |
2 similar comments
|
Let me see if I can fix that for you! This might take a moment... |
|
Let me see if I can fix that for you! This might take a moment... |
|
@spackbot fix style again |
|
Let me see if I can fix that for you! This might take a moment... |
|
I was able to run ==> Running style checks on spack:
selected: isort, mypy, flake8
==> Modified files:
lib/spack/spack/cmd/style.py
==> Running isort checks
isort checks were clean
==> Running mypy checks
Success: no issues found in 508 source files
mypy checks were clean
==> Running flake8 checks
lib/spack/spack/cmd/style.py:30: [W291] trailing whitespace
flake8 found errorsKeep in mind that I cannot fix your flake8 errors, so if you have any you'll need to fix them and update the pull request." I wasn't able to make any changes, but please see the message above for any remaining issues! |
|
Let me see if I can fix that for you! This might take a moment... |
|
I was able to run ==> Running style checks on spack:
selected: isort, mypy, flake8
==> Modified files:
lib/spack/spack/cmd/style.py
==> Running isort checks
isort checks were clean
==> Running mypy checks
Success: no issues found in 508 source files
mypy checks were clean
==> Running flake8 checks
lib/spack/spack/cmd/style.py:30: [W291] trailing whitespace
flake8 found errors
Keep in mind that I cannot fix your flake8 errors, so if you have any you'll need to fix them and update the pull request. |
|
@spackbot fix style |
|
Let me see if I can fix that for you! This might take a moment... |
|
I was able to run ==> Running style checks on spack:
selected: isort, mypy, flake8
==> Modified files:
lib/spack/spack/cmd/style.py
==> Running isort checks
isort checks were clean
==> Running mypy checks
Success: no issues found in 508 source files
mypy checks were clean
==> Running flake8 checks
lib/spack/spack/cmd/style.py:30: [W291] trailing whitespace
flake8 found errors
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. |
|
@spackbot helloooooo |
|
👋️ |
|
@spackbot fix style! |
|
Let me see if I can fix that for you! This might take a moment... |
1 similar comment
|
Let me see if I can fix that for you! This might take a moment... |
|
@spackbot fix style |
|
Let me see if I can fix that for you! This might take a moment... |
|
I was able to run ==> Running style checks on spack:
selected: isort, mypy, flake8
==> Modified files:
==> Running isort checks
isort checks were clean
==> Running mypy checks
Success: no issues found in 508 source files
mypy checks were clean
==> Running flake8 checks
flake8 checks were clean
==> spack style checks were clean
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. |
|
@spackbot fix style |
|
Let me see if I can fix that for you! This might take a moment... |
|
Here is the output from ==> Running style checks on spack:
selected: isort, mypy, flake8
==> Modified files:
lib/spack/spack/cmd/style.py
==> Running isort checks
isort checks were clean
==> Running mypy checks
Success: no issues found in 508 source files
mypy checks were clean
==> Running flake8 checks
lib/spack/spack/cmd/style.py:30: [W291] trailing whitespace
flake8 found errors
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. |
|
@spackbot fix style! |
|
Let me see if I can fix that for you! This might take a moment... |
|
I was able to run spack style --fix==> Running style checks on spack:
selected: isort, mypy, flake8
==> Modified files:
lib/spack/spack/cmd/style.py
==> Running isort checks
isort checks were clean
==> Running mypy checks
Success: no issues found in 508 source files
mypy checks were clean
==> Running flake8 checks
lib/spack/spack/cmd/style.py:30: [W291] trailing whitespace
flake8 found errors
|
|
@spackbot hello! |
1 similar comment
|
@spackbot hello! |
|
@spackbot hello again |
|
Hola! |
|
@spackbot fix style |
|
Let me see if I can fix that for you! This might take a moment... |
|
I was able to run spack style --fix==> Running style checks on spack
selected: isort, mypy, flake8
==> Modified files
==> Running isort checks
isort checks were clean
==> Running mypy checks
Success: no issues found in 514 source files
mypy checks were clean
==> Running flake8 checks
flake8 checks were clean
==> spack style checks were clean
|
Signed-off-by: vsoch vsoch@users.noreply.github.com