Skip to content

Readability edits: API Design Across Languages section #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Sep 9, 2020
Merged

Readability edits: API Design Across Languages section #220

merged 18 commits into from
Sep 9, 2020

Conversation

@alice
Copy link
Contributor

@alice alice commented Jul 7, 2020 •
edited by pr-preview bot
Loading

@hober hober requested review from atanassov, dbaron and hober July 8, 2020 15:51
dbaron
dbaron suggested changes Jul 21, 2020
View reviewed changes
Copy link
Member

@dbaron dbaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I'm reviewing this one commit at a time; I got through a bunch without any comments, but I have a bunch of comments on this one (which is in the middle).

dbaron
dbaron suggested changes Jul 21, 2020
View reviewed changes
dbaron
dbaron suggested changes Jul 22, 2020
View reviewed changes
dbaron
dbaron previously requested changes Jul 22, 2020
View reviewed changes
@dbaron
Copy link
Member

dbaron commented Jul 22, 2020

I've now reviewed all the commits in this PR.

alice
alice commented Sep 9, 2020
View reviewed changes
alice
alice commented Sep 9, 2020
View reviewed changes
alice
alice commented Sep 9, 2020
View reviewed changes
alice
alice commented Sep 9, 2020
View reviewed changes
cynthia
cynthia reviewed Sep 9, 2020
View reviewed changes
alice
alice commented Sep 9, 2020
View reviewed changes
hober
hober approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@hober hober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for all your hard work on this, @alice.

cynthia
cynthia approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@cynthia cynthia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

torgo
torgo reviewed Sep 9, 2020
View reviewed changes
alice
alice commented Sep 9, 2020
View reviewed changes
Alice and others added 2 commits September 9, 2020 15:54
Update index.bs
f009415
@torgo
Update index.bs
3f8ead3 
Co-authored-by: Daniel Appelquist <dan@torgo.com>
alice
alice commented Sep 9, 2020
View reviewed changes
@alice alice dismissed dbaron’s stale review September 9, 2020 05:59

David is on leave, and I believe I've addressed all the changes.

@alice alice merged commit 3891b4f into w3ctag:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@torgo torgo torgo left review comments

@atanassov atanassov Awaiting requested review from atanassov

+3 more reviewers

@dbaron dbaron dbaron left review comments

@hober hober hober approved these changes

@cynthia cynthia cynthia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alice @dbaron @hober @cynthia @torgo