Repository navigation
Why does menuitemradio inherit from menuitemcheckbox? #1347
Description
It seems a little odd that menuitemradio inherits from menuitemcheckbox, but that radio doesn't inherit from checkbox. I tried to find the answer in the spec and the only indication is a "(see structure)" text next to the superclass listing. If there's a reason for this difference, it would be good to explain it in the description of the role. If not it might be worth changing the inheritance so it is consistent.
Metadata
Metadata
Assignees
Labels
No labels
Activity
carmacleod commentedon Oct 28, 2020
I agree that it is definitely odd.
It is because folks didn't want to support aria-expanded on radio (but they were ok with it on menuitemradio).
Some discussion in this issue #1277 and its corresponding PR #1278
JAWS-test commentedon Oct 28, 2020
I don't understand the argument. menuitemradio could have "menuitem" and "radio" as superclass role instead of "menuitemcheckbox" and "radio". aria-expanded would then inherit it from menuitem and everything would be ok
carmacleod commentedon Oct 28, 2020
People wanted to remove the multiple inheritance.
However, I believe we could just have
menuitemradiosubclassmenuitemdirectly, and make it supportaria-checked.That would probably make the structure clearer (and more consistent).
I'll add the "agenda" label to discuss this possibility.
jnurthen commentedon Oct 28, 2020
PR welcome for the change @carmacleod suggested above.