remove reference to taxonomy File #1070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is insufficient to close #672, I think... the PR would need to remove all mentions of RDF throughout the spec. |
|
Thanks for continuing to push forward on this @jnurthen! |
joanmarie
approved these changes
Oct 2, 2019
mcking65
requested changes
Oct 10, 2019
| <li>references to related concepts in other specifications;</li> | ||
| <li>use of <abbr title="Web Ontology Language">OWL</abbr> to provide a type hierarchy allowing for <a>semantic</a> inheritance (similar to a <a>class</a> hierarchy); and</li> | ||
| <li>supported <a>states</a> and <a>properties</a> for each role (e.g., a <rref>checkbox</rref> supports being checked via <sref>aria-checked</sref>).</li> | ||
| </ul> |
There was a problem hiding this comment.
Unrelated to this PR, but this list is oddly incomplete.
| <dd>rdfs:subClassOf</dd> | ||
| </dl> | ||
| <p>The <a>role</a> that the current subclassed role extends in the <a>taxonomy</a>. This extension causes all the properties and constraints of the superclass role to propagate to the subclass role. Other than well known stable specifications, inheritance may be restricted to items defined inside this specification, so that external items cannot be changed and affect inherited <a>classes</a>.</p> | ||
| <p>The <a>role</a> that the current subclassed role extends in the Roles Model. This extension causes all the properties and constraints of the superclass role to propagate to the subclass role. Other than well known stable specifications, inheritance may be restricted to items defined inside this specification, so that external items cannot be changed and affect inherited <a>classes</a>.</p> |
There was a problem hiding this comment.
Is it all constraints? Unsure of this. Example, naming constraints are not inherrited. Default values are not inherrited.
Co-Authored-By: Matt King <a11yThinker@Gmail.com>
Co-Authored-By: Matt King <a11yThinker@Gmail.com>
Co-Authored-By: Matt King <a11yThinker@Gmail.com>
Co-Authored-By: Matt King <a11yThinker@Gmail.com>
|
@mcking65 please re-review |
michael-n-cooper
approved these changes
Oct 16, 2019
There was a problem hiding this comment.
I don't object to merging in this in its current state. There are a couple things I noticed which might merit addressing before merging, but which could also wait for later work:
- There is a retained reference to "XHTML" which I think makes less sense to keep given the other changes in this pull request, as it has less context than ever.
- Much of the edits involve replacing "RDF Taxonomy" with "Roles Model". However, I think the roles model isn't well introduced. Perhaps the RDF Taxonomy wasn't either, but there was some inherent understanding via the reference to RDF. Without that, new readers wouldn't understand the structure we're using. So an introductory paragraph in the top of the Roles Model section might help contextualize later uses of the term.
mcking65
approved these changes
Oct 20, 2019
jnurthen
added a commit
that referenced
this pull request
Oct 21, 2019
* Remove RDF References * change example from directory
carmacleod
pushed a commit
that referenced
this pull request
May 7, 2020
* Remove RDF References * change example from directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #672
Preview | Diff