revise meter authoring advice #1129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to have similar authoring expectations to HTML’s meter element, the authoring adivce for the meter role is updated to remove the requirement for aria-valuemin and max, and instead indicate these attributes should have implicit defult values, similar to progressbar. removes aria-valuemax and min from the required states and properties row of the characteristics table, and moves them to an Implicit Value for Role row. Adds meter’s required aria-valuenow to the Fallback values for missing required attributes table
zcorpan
reviewed
Dec 7, 2019
zcorpan
approved these changes
Dec 10, 2019
6 tasks
carmacleod
reviewed
Feb 29, 2020
carmacleod
approved these changes
Feb 29, 2020
|
@jnurthen This PR is ready for final review. |
jnurthen
pushed a commit
that referenced
this pull request
Apr 3, 2020
* to have similar authoring expectations to HTML’s meter element, the authoring advice for the meter role is updated to remove the requirement for aria-valuemin and max, and instead indicate these attributes should have implicit defult values, similar to progressbar. * removes aria-valuemax and min from the required states and properties row of the characteristics table, and moves them to an Implicit Value for Role row. * Adds meter’s required aria-valuenow to the Fallback values for missing required attributes table Co-authored-by: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>
|
@scottaohara APG is very near to close this issue. Would you like to have a final look? |
carmacleod
added a commit
that referenced
this pull request
May 7, 2020
* to have similar authoring expectations to HTML’s meter element, the authoring advice for the meter role is updated to remove the requirement for aria-valuemin and max, and instead indicate these attributes should have implicit defult values, similar to progressbar. * removes aria-valuemax and min from the required states and properties row of the characteristics table, and moves them to an Implicit Value for Role row. * Adds meter’s required aria-valuenow to the Fallback values for missing required attributes table Co-authored-by: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1123
to have similar authoring expectations to HTML’s meter element, the authoring adivce for the meter role is updated to remove the requirement for aria-valuemin and max, and instead indicate these attributes should have implicit defult values, similar to progressbar.
removes aria-valuemax and min from the required states and properties row of the characteristics table, and moves them to an Implicit Value for Role row.
Adds meter’s required aria-valuenow to the Fallback values for missing required attributes table
Preview | Diff