Skip to content

Update fallback table #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2020
Merged

Update fallback table #1208

merged 2 commits into from
Mar 11, 2020

Conversation

@carmacleod
Copy link
Contributor

@carmacleod carmacleod commented Feb 29, 2020 •
edited by pr-preview bot
Loading

Resolves #1206

Preview | Diff

scottaohara
scottaohara approved these changes Mar 1, 2020
View reviewed changes
Copy link
Member

@scottaohara scottaohara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

jnurthen
jnurthen reviewed Mar 4, 2020
View reviewed changes
@carmacleod
Make fallback value for separator aria-valuenow consistent with scrol…
f2c6e1c 
…lbar and slider.

Also:
- add missing </div>
- fix broken link to (missing #) authorErrorDefaultValuesTable
- remove 2 extraneous class="specref" in #authorErrorDefaultValuesTable links
@carmacleod
Copy link
Contributor Author

carmacleod commented Mar 4, 2020

@jnurthen This PR is ready for final review.

@jnurthen jnurthen requested a review from schne324 March 5, 2020 18:22
schne324
schne324 approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@schne324 schne324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jnurthen jnurthen merged commit 9c73b5b into master Mar 11, 2020
carmacleod added a commit that referenced this pull request May 7, 2020
@carmacleod
Make fallback value for separator aria-valuenow consistent with scrol…
069c353 
…lbar and slider. (#1208)
@jnurthen jnurthen deleted the issue1206 branch July 23, 2020 22:27
jnurthen pushed a commit that referenced this pull request Sep 10, 2020
@carmacleod @jnurthen
Make fallback value for separator aria-valuenow consistent with scrol…
5569456 
…lbar and slider. (#1208)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnurthen jnurthen jnurthen left review comments

@schne324 schne324 schne324 approved these changes

@scottaohara scottaohara scottaohara approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fallback table for required attribute values needs updating

5 participants

@carmacleod @jnurthen @schne324 @scottaohara