Skip to content

Change aria-keyshortcuts initial keyword from Indicates to Defines. #1626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2022
Merged

Change aria-keyshortcuts initial keyword from Indicates to Defines. #1626

merged 1 commit into from
Jan 11, 2022

Conversation

@cookiecrook
Copy link
Contributor

@cookiecrook cookiecrook commented Oct 14, 2021 •
edited by pr-preview bot
Loading

Resolves #1625.

Preview | Diff

@cookiecrook
Copy link
Contributor Author

cookiecrook commented Oct 14, 2021

@jnurthen ready for merge. Thanks @aleventhal and @scottaohara

@pkra
Copy link
Member

pkra commented Jan 10, 2022

ping @jnurthen.

This resolves #1625 which is technically in the 1.2 milestone. CI (travis) is marked hanging - not sure whether this can/should be merged.

@jnurthen
Copy link
Member

jnurthen commented Jan 10, 2022

ping @jnurthen.

This resolves #1625 which is technically in the 1.2 milestone. CI (travis) is marked hanging - not sure whether this can/should be merged.

Lets merge it (also stable) - We don't use travis any more so don't worry about anything hanging if it is as simple as this one.

@pkra pkra self-assigned this Jan 11, 2022
@pkra pkra added this to the ARIA 1.3 milestone Jan 11, 2022
@pkra pkra merged commit 028bbbb into main Jan 11, 2022
@pkra pkra deleted the issue-1625 branch January 11, 2022 08:00
@pkra pkra mentioned this pull request Jan 11, 2022
Closed
github-actions bot added a commit that referenced this pull request Jan 11, 2022
@cookiecrook @github-actions
Change aria-keyshortcuts initial keyword from Indicates to Defines. R…
efca6cf 
…esolves Issue #1625. (#1626)

SHA: 028bbbb
Reason: push, by @pkra

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
pkra pushed a commit that referenced this pull request Jul 14, 2022
@cookiecrook @pkra
Change aria-keyshortcuts initial keyword from Indicates to Defines. R…
d92f778 
…esolves Issue #1625. (#1626)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pkra pkra pkra approved these changes

@aleventhal aleventhal aleventhal approved these changes

@scottaohara scottaohara scottaohara approved these changes

Assignees

@pkra pkra

Labels

None yet

Projects

None yet

Milestone

2023

Development

Successfully merging this pull request may close these issues.

aria-keyshortcuts uses incorrect term "Indicates"; should use "Defines"

6 participants

@cookiecrook @pkra @jnurthen @aleventhal @scottaohara