Skip to content

Use rref instead of ref, which is probably a typo #1631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2021
Merged

Use rref instead of ref, which is probably a typo #1631

merged 1 commit into from
Nov 4, 2021

Conversation

@saschanaz
Copy link
Member

@saschanaz saschanaz commented Oct 30, 2021 •
edited by pr-preview bot
Loading

Resolves one of the issues found in #1623.

Preview | Diff

@saschanaz saschanaz mentioned this pull request Oct 30, 2021
Closed
@saschanaz saschanaz changed the title Use rref instead ref, which is probably a typo Use rref instead of ref, which is probably a typo Oct 30, 2021
@jnurthen jnurthen self-requested a review November 4, 2021 17:14
@jnurthen jnurthen added the editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo label Nov 4, 2021
@cookiecrook cookiecrook self-requested a review November 4, 2021 17:15
cookiecrook
cookiecrook requested changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@cookiecrook cookiecrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be a stickler, but can we get a clean PR that doesn't include the whitespace changes? Those screw up history and git blame, among other things.

@jnurthen
Copy link
Member

jnurthen commented Nov 4, 2021

Sorry to be a stickler, but can we get a clean PR that doesn't include the whitespace changes? Those screw up history and git blame, among other things.

Agree - the whitespace changes are also going to mess up merges of #1633

@saschanaz saschanaz mentioned this pull request Nov 4, 2021
Merged
@saschanaz
Copy link
Member Author

saschanaz commented Nov 4, 2021

Those screw up history and git blame, among other things.

I believe squashing is not the only merging method on GitHub, but yeah, depends on each repo's policy...

@jnurthen jnurthen merged commit 43b08b9 into w3c:main Nov 4, 2021
@jnurthen
Copy link
Member

jnurthen commented Nov 4, 2021

Thanks @saschanaz

@saschanaz saschanaz deleted the rref-typo branch November 4, 2021 18:32
jnurthen pushed a commit that referenced this pull request Nov 4, 2021
@saschanaz @jnurthen
Use rref instead ref, which is probably a typo (#1631)
ca56693
@saschanaz saschanaz mentioned this pull request Nov 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cookiecrook cookiecrook cookiecrook requested changes

@jnurthen jnurthen jnurthen approved these changes

@scottaohara scottaohara scottaohara approved these changes

Assignees

No one assigned

Labels

editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@saschanaz @jnurthen @cookiecrook @scottaohara