Change tooltip to name prohibited #2670
Open
+1
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this PR attempts to close #2668 As mentioned in the referenced issue, authors naming a tooltip either doesn't consistently work with current AT, or it can introduce unintended author errors where if a tooltip is named - and associated with an element via `aria-describedby`, only the name is exposed and not the longer description that a user can see. The reason this changed to name prohibited, is because by removing the 'name from author', only 'name from contents' remained.... and there is no other role in the ARIA spec that allows name from content by itself. All other similar roles are identified as name prohibited. So, while this PR initially only changes the "name from" section from listing "author and contents" to "prohibited" - i assume a note will need to be added to further describe this change and the rational behind it. it might be worth also resolving #2507 in this PR. but before I do that, I will wait for discussion on this initial PR.
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR attempts to close #2668
As mentioned in the referenced issue, authors naming a tooltip either doesn't consistently work with current AT, or it can introduce unintended author errors where if a tooltip is named - and associated with an element via
aria-describedby, only the name is exposed and not the longer description that a user can see.The reason this changed to name prohibited, is because by removing the 'name from author', only 'name from contents' remained.... and there is no other role in the ARIA spec that allows name from content by itself. All other similar roles are identified as name prohibited.
So, while this PR initially only changes the "name from" section from listing "author and contents" to "prohibited" - i assume a note will need to be added to further describe this change and the rational behind it.
it might be worth also resolving #2507 in this PR. but before I do that, I will wait for discussion on this initial PR.
Test, Documentation and Implementation tracking
Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.
Preview | Diff