editorial: update roleInfo.js (manually) #2624
Conversation
common/script/roleInfo.js
Outdated
| } | ||
| ] | ||
| }, | ||
| "associationlist": { |
There was a problem hiding this comment.
This is correct following #1662
common/script/roleInfo.js
Outdated
common/script/roleInfo.js
Outdated
| "fragID": "none", | ||
| "localprops": [], | ||
| "parentRoles": [] | ||
| "parentRoles": [ |
There was a problem hiding this comment.
This change is due to none becoming the default and presentation the alias in #1945
common/script/roleInfo.js
Outdated
| { | ||
| "is": "property", | ||
| "name": "aria-label", | ||
| "name": "aria-braillelabel", |
There was a problem hiding this comment.
git diff being confused here - paragraph gained braillelabel (disallowed) while presentation lost it's information (cf. earlier comment on "none" / #1945).
| "widget" | ||
| ], | ||
| "localprops": [ | ||
| { |
common/script/roleInfo.js
Outdated
| } | ||
| ] | ||
| }, | ||
| "sectionfooter": { |
common/script/roleInfo.js
Outdated
| } | ||
| ] | ||
| }, | ||
| "sectionheader": { |
common/script/roleInfo.js
Outdated
| ], | ||
| "localprops": [ | ||
| { | ||
| "is": "property", |
| "section" | ||
| ], | ||
| "localprops": [ | ||
| { |
| "section" | ||
| ], | ||
| "localprops": [ | ||
| { |
| "section" | ||
| ], | ||
| "localprops": [ | ||
| { |
| "section" | ||
| ], | ||
| "localprops": [ | ||
| { |
| "section" | ||
| ], | ||
| "localprops": [ | ||
| { |
common/script/roleInfo.js
Outdated
| "parentRoles": [ | ||
| "section" | ||
| ], | ||
| "parentRoles": [], |
| "section" | ||
| ], | ||
| "localprops": [ | ||
| { |
| "disallowed": false, | ||
| "deprecated": false | ||
| }, | ||
| { |
| "section" | ||
| ], | ||
| "localprops": [ | ||
| { |
common/script/roleInfo.js
Outdated
| } | ||
| ] | ||
| }, | ||
| "presentation": { |
| "section" | ||
| ], | ||
| "localprops": [ | ||
| { |
| "section" | ||
| ], | ||
| "localprops": [ | ||
| { |
| "section" | ||
| ], | ||
| "localprops": [ | ||
| { |
| "section" | ||
| ], | ||
| "localprops": [ | ||
| { |
| "section" | ||
| ], | ||
| "localprops": [ | ||
| { |
| "section" | ||
| ], | ||
| "localprops": [ | ||
| { |
Thank you. I added comments linking to the PRs that caused the changes (and explained how git diff is struggling in one situation). |
|
Discussed in yesterday's editors' call https://www.w3.org/2025/09/10-aria-editors-minutes.html#73b0 |
|
Ugh, I forgot that squashing the commits in the first PR means I can't just switch the branch. Lovely. I'll force push an update. Hopefully my comments will survive. |
|
Double ugh - CI run of prettier is reformatting roleInfo.js back to what it was 42350b4 |
Updates roleInfo using the current manual process. Part of #2501
b29bb5e to
2f9ec60
Compare
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| }, | ||
| ], | ||
| }, | ||
| associationlist: { |
There was a problem hiding this comment.
This is correct following #1662
| name: "image", | ||
| fragID: "image", | ||
| parentRoles: [], | ||
| parentRoles: ["section"], |
| fragID: "none", | ||
| localprops: [], | ||
| parentRoles: [], | ||
| parentRoles: ["structure"], |
There was a problem hiding this comment.
This change is due to none becoming the default and presentation the alias in #1945
| { | ||
| is: "property", | ||
| name: "aria-label", | ||
| name: "aria-braillelabel", |
There was a problem hiding this comment.
git diff being confused here - paragraph gained braillelabel (disallowed) while presentation lost it's information (cf. earlier comment on "none" / #1945).
| }, | ||
| ], | ||
| }, | ||
| sectionfooter: { |
| }, | ||
| ], | ||
| }, | ||
| sectionheader: { |
|
@jnurthen following a rebase, github lost the connection to some of the earlier comments - I re-added them (they appear twice in this thread but once in the "Files Changed" view. Could you take a look so we can merge? |
|
@jnurthen can I merge this? |
SHA: cc055a7 Reason: push, by pkra Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Updates roleInfo using the current manual process. Changes are due to #2076, #1662, #1945, #2581, #1931, #1991, #1862
Part of #2501
Also resolves #2234