Skip to content

Update mapping for aria-errormessage #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2023
Merged

Update mapping for aria-errormessage #179

merged 1 commit into from
Aug 16, 2023

Conversation

@cookiecrook
Copy link
Contributor

@cookiecrook cookiecrook commented Jun 3, 2023 •
edited by pr-preview bot
Loading

Closes #138

Update macOS mapping for aria-errormessage to AXErrorMessageElements

Implementation

Preview | Diff

@spectranaut
Copy link
Contributor

spectranaut commented Jun 15, 2023

I don't see this in the blink code, @cookiecrook -- I don't see an issue for it either. Why did you write "shipping" above?

Looks to me like we need issues for both blink and gecko. I'll submit a test fix for the core-aam tests, however.

@spectranaut spectranaut mentioned this pull request Jun 15, 2023
Merged
@spectranaut
Copy link
Contributor

spectranaut commented Jun 15, 2023

about the tests, I'm keeping the core-aam tests update for now -- so if there is a change to the mapping tables there is a change to the wpt/core-aam tests. We have some hack-y ways to run them and eventually we will translate them to a newer test format.

@cookiecrook
Copy link
Contributor Author

cookiecrook commented Jun 16, 2023

I don't see this in the blink code, @cookiecrook -- I don't see an issue for it either. Why did you write "shipping" above?

I must’ve read too much into this comment.

@spectranaut
Copy link
Contributor

spectranaut commented Jun 16, 2023

ok I found the issue, and I guess this is implementation commitment since @aleventhal commented on it but I'll wait until he sees this to merge: https://bugs.chromium.org/p/chromium/issues/detail?id=1403266&sort=pri&q=aria-errormessage&can=2

@spectranaut spectranaut merged commit 37697d3 into main Aug 16, 2023
github-actions bot added a commit that referenced this pull request Aug 16, 2023
@cookiecrook @github-actions
Update mapping for aria-errormessage (#179)
b0ffccd 
SHA: 37697d3
Reason: push, by spectranaut

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spectranaut spectranaut spectranaut approved these changes

@aleventhal aleventhal Awaiting requested review from aleventhal

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Core-AAM aria-errormessage to take multiple element references

3 participants

@cookiecrook @spectranaut