Skip to content

[css-typed-om] CSSMathClamp’s min and max props conflict with CSSNumericValue’s methods #855

Closed

Description

@miyaokamarina

CSSMathClamp’s min and max attributes are incompatible with CSSNumericValue’s methods min and max.

This design violates the Liskov substitution principle. Also current version of the interface cannot be properly typed with TypeScript and Flow.

Possible compatible names for these attributes are lower and upper.

Activity

  1. tabatkins commented on May 7, 2019

    @tabatkins
    Member

    Ah, indeed, that's a silly mistake on my part. It doesnt' just violate Liskov, it violates WebIDL!

  2. jodinathan commented on Jun 14, 2021

    @jodinathan

    is this going to be fixed?
    shouldn't have min and max as operation and attribute =/

  3. tabatkins commented on Jun 15, 2021

    @tabatkins
    Member

    Thanks for the ping! Fixed now.

  4. added a commit that references this issue on Jul 28, 2025
    bd98097
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions