You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[css-grid] New stretch "auto" tracks steps needs more text for indefinite height grid containers #1866
We've implemented that in Blink and WebKit but found a regression due to this change.
The example is really simple (the trick is in the min-height part):
In this case the height of the grid container is indefinite, the size of the row is calculated as the height of the text (20px) . Then when we are in the Stretch auto Tracks step we don't stretch the track as the free space is not definite.
The expected result is that the row has 200px height, however it has just the text height (20px).
The problem is that this new step lacks some text like the one we have for flexible tracks:
If using this flex fraction would cause the grid to be smaller than the grid container’s min-width/height (or larger than the grid container’s max-width/height), then redo this step, treating the free space as definite and the available grid space as equal to the grid container’s content box size when it’s sized to its min-width/height (max-width/height).
I believe we'd need to add something like this to the new step too, to avoid this issue.
Activity
tabatkins commentedon Oct 13, 2017
Fixed, thanks! Let us know if the edits are adequate.
mrego commentedon Oct 16, 2017
Thanks for the quick fix, the text looks good to me.
I'd add a new test case with the fix in Blink.
mrego commentedon Oct 23, 2017
Test case added in web-platform-tests/wpt#7782.