Skip to content

[css-view-transitions-1] What is the size of the group pseudo for the root element? #10177

Closed

Description

@nt1m

From @mattwoodrow from investigating https://bugs.webkit.org/show_bug.cgi?id=272186:

Chrome seems to be setting the size of their ::view-transition-group element to that of the snapshot containing block. That seems wrong, but visually what you’d expect to happen.

Capture the image algorithm has a special case for sizing the image when capturing the root, I suspect Update pseudo-element styles should have the equivalent wording for setting the width/height style properties.

Activity

  1. nt1m commented on Apr 5, 2024

    @nt1m
    MemberAuthor
  2. noamr commented on Apr 5, 2024

    @noamr
    Collaborator

    Sounds reasonable to me, will wait for Vlad/Khush to confirm. Happy to make the edit.

  3. khushalsagar commented on Apr 8, 2024

    @khushalsagar
    Member

    That seems wrong, but visually what you’d expect to happen.

    Just to confirm, the error is that we're using the border-box for the document element here. Instead it should be the snapshot containing block size similar to when we do this for the old DOM here.

    SGTM. Thanks for spotting this!

  4. added a commit that references this issue on Apr 8, 2024
    e54d4f5
  5. mattwoodrow commented on Apr 8, 2024

    @mattwoodrow
    Contributor

    Just to confirm, the error is that we're using the border-box for the document element here. Instead it should be the snapshot containing block size similar to when we do this for the old DOM here.

    Yes, exactly. Thank you!

  6. added a commit that references this issue on Apr 9, 2024
    e0805b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions