Skip to content

[css-multicol] column-span examples are unclear about visual/source order of text #1087

Closed

Description

@dbaron

The examples in the section on column-span are rather difficult to understand because it's not obvious, looking at the examples visually, what the order of the text in the source document is.

It would probably be much clearer if the text used real sentences rather than bits of alphabet, and in particular real sentences that have a relatively obvious order associated with the pieces of the sentence.

Activity

  1. self-assigned this
    on Apr 6, 2017
  2. rachelandrew commented on Aug 12, 2017

    @rachelandrew
    Contributor

    I agree, and in general I think these could be made clearer by turning each into an SVG (rather than these mocked up code examples). More like the examples in the grid spec. Unless there is some issue with that I'll create SVG images that clearly show these examples.

  3. frivoal commented on Aug 13, 2017

    @frivoal
    Collaborator

    No problem at all, we ended up with these drawings because they are simpler to create, not because anyone prefers that sorts of things.

  4. rachelandrew commented on Mar 8, 2018

    @rachelandrew
    Contributor

    I've added SVG versions of the examples in Section 2. I think these are better, and using the same text throughout should help to demonstrate the different examples in a more obvious way.

    Unless anyone has any feedback or suggestions on how to improve these I'll continue and do the same with the more fiddly ones in the column-span section.

  5. frivoal commented on Mar 8, 2018

    @frivoal
    Collaborator

    These look way better than what they replaced. Thanks a ton.

  6. rachelandrew commented on Mar 20, 2018

    @rachelandrew
    Contributor

    I have now replaced all of the examples. I've tried to remain faithful to the intent of the originals. I suggest that if any of the images or indeed the examples themselves still need work individual issues are raised. I have a big Sketch file of all of these so can make any changes that we think would make things clearer, therefore I'll close this issue.

  7. frivoal commented on Mar 21, 2018

    @frivoal
    Collaborator

    Can you put the Sketch file in the repository, just in case we need to make edits to these 7 years from now and you're not longer editing the spec by then? No need to link to them from anything, just put them in the same directory.

  8. rachelandrew commented on Mar 21, 2018

    @rachelandrew
    Contributor

    good call, I'll tidy it up a bit and do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions